Skip to content

Conversation

@JrAdhoc
Copy link
Contributor

@JrAdhoc JrAdhoc commented Oct 18, 2024

No description provided.

sebalix and others added 30 commits October 18, 2024 13:05
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/fr/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/pt_BR/
OCA-git-bot and others added 16 commits October 18, 2024 13:05
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/
Currently translated at 12.5% (1 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/es/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-17.0/website-17.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_google_tag_manager/
…anager

Adding script before the wrapwrap element affects style [1] and hide the
nav bar behind of the main menu, so it is required adding it after the
wrapwrap element, the same way as [2] does it.

Reference:

- [1] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/static/src/scss/website.scss#L200
- [2] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/views/website_templates.xml#L151
@JrAdhoc JrAdhoc mentioned this pull request Oct 18, 2024
11 tasks
@JrAdhoc JrAdhoc force-pushed the 18.0-mig-website_google_tag_manager branch 5 times, most recently from 75a0af7 to 73c2423 Compare October 30, 2024 15:38
Copy link

@lef-adhoc lef-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JrAdhoc JrAdhoc force-pushed the 18.0-mig-website_google_tag_manager branch from 73c2423 to 1fbaabc Compare November 12, 2024 18:12
@atchuthan
Copy link
Member

pre-commit and tests are failing in this PR. Please check @JrAdhoc

@dc-oerp
Copy link
Member

dc-oerp commented Feb 3, 2025

Hi @JrAdhoc
Any updates on this module upgrade?

@StefanRijnhart
Copy link
Member

Closing in favor of #1081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.