[MIG] website_google_tag_manager: Migration to 18.0 #1081

SodexisTeam · 2024-12-24T07:30:30Z

No description provided.

StefanRijnhart · 2025-01-31T11:13:32Z

/ocabot rebase

OCA-git-bot · 2025-01-31T11:13:38Z

@StefanRijnhart The rebase process failed, because command git push --force sodexis tmp-pr-1081:18.0-mig-website_google_tag_manager failed with output:

remote: Permission to sodexis/website.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/sodexis/website/': The requested URL returned error: 403

StefanRijnhart · 2025-01-31T11:13:54Z

@SodexisTeam can you rebase to fix tests?

amkarthik · 2025-01-31T13:59:02Z

@StefanRijnhart
Done.

StefanRijnhart · 2025-01-31T15:27:10Z

@amkarthik Did something not go as planned? I'm surprised to see that commits (and actual changes) that were merged to the 18.0 branch recently are now showing up here in this branch, as if the 18.0 branch was rebased onto this PR's branch rather than the other way around.

amkarthik · 2025-02-04T06:28:12Z

@StefanRijnhart
I triggered "git pull oca 18.0 --rebase" to rebase the commits from oca repo and pushed it to PR branch
I am not sure why it's showing as you mentioned.
Please let me know If I miss something.
I have a backup of PR branch without any modifications in it.

StefanRijnhart

Thanks, all good now after the latest push!

StefanRijnhart · 2025-02-04T07:06:01Z

/ocabot migration website_google_tag_manager

desdelinux · 2025-02-05T18:31:59Z

Hi @StefanRijnhart @pedrobaeza this is ready :)

OCA-git-bot · 2025-02-05T18:59:46Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

JrAdhoc · 2025-02-11T17:42:02Z

website_google_tag_manager/views/website_templates.xml

+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+<odoo>
+    <template id="layout" inherit_id="website.layout">
+        <xpath expr="//div[@id='wrapwrap']" position="after">


This part should be added right after the opening tag, as mentioned in this documentation

@SodexisTeam what do you think? Is this something that can be improved?

It works if the code snippet is inside the <body>. However, the later it is added, the later it is loaded.
Which is not ideal, because you might miss some visitors. If this can be improved, that would be great

Given that no response from @SodexisTeam has come in three months, @JrAdhoc I see you implemented this in your own migration PR of this module with the failing CI (#1064). Would you like to pick it up there?

We made the correction. Please check @StefanRijnhart @TomAlbrechtQuatra @JrAdhoc

Thanks! Is this alright with you @JrAdhoc?

StefanRijnhart · 2025-05-08T10:37:08Z

/ocabot migration website_google_tag_manager

pilarvargas-tecnativa

Please reduce administrative commits

* [ADD] New module 'website_google_tag_manager' * [FIX] website_google_tag_manager - Added OCA as author * [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager') * [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (8 of 8 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/es_AR/

Currently translated at 72.7% (8 of 11 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/fr_FR/

Currently translated at 12.5% (1 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/

Currently translated at 100.0% (8 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/es/

Currently translated at 100.0% (8 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-17.0/website-17.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_google_tag_manager/

…anager Adding script before the wrapwrap element affects style [1] and hide the nav bar behind of the main menu, so it is required adding it after the wrapwrap element, the same way as [2] does it. Reference: - [1] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/static/src/scss/website.scss#L200 - [2] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/views/website_templates.xml#L151

atchuthan · 2025-07-01T13:38:23Z

Please reduce administrative commits

Reduced commits as per https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
Please review @pilarvargas-tecnativa

StefanRijnhart · 2025-07-23T09:05:40Z

Looks like all comments have been addressed!

/ocabot merge nobump

OCA-git-bot · 2025-07-23T09:05:47Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1081-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot · 2025-07-23T09:11:48Z

Congratulations, your PR was merged at 09c283d. Thanks a lot for contributing to OCA. ❤️

SodexisTeam force-pushed the 18.0-mig-website_google_tag_manager branch from acbeb4f to 842d5fe Compare December 31, 2024 10:23

amkarthik force-pushed the 18.0-mig-website_google_tag_manager branch from 580e1de to 5ebcf9a Compare February 4, 2025 06:23

StefanRijnhart approved these changes Feb 4, 2025

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Feb 4, 2025

OCA-git-bot mentioned this pull request Feb 4, 2025

Migration to version 18.0 #1062

Open

11 tasks

desdelinux approved these changes Feb 5, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 5, 2025

OCA-git-bot added the ready to merge label Feb 5, 2025

JrAdhoc reviewed Feb 11, 2025

View reviewed changes

atchuthan force-pushed the 18.0-mig-website_google_tag_manager branch from 5ebcf9a to 9bd08e3 Compare May 8, 2025 10:12

StefanRijnhart mentioned this pull request May 8, 2025

[18.0][MIG]website_google_tag_manager: Migration to 18.0 #1064

Closed

pilarvargas-tecnativa suggested changes Jun 19, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jun 19, 2025

atchuthan force-pushed the 18.0-mig-website_google_tag_manager branch from 9bd08e3 to 0cb1635 Compare July 1, 2025 13:34

sebalix and others added 5 commits July 1, 2025 19:06

[11.0][MIG] website_google_tag_manager: Migration to 11.0

08e9803

[12.0][MIG] website_google_tag_manager: Migration to v12

ae55b40

Update translation files

0e7b914

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] website_js_below_the_fold: Migration to 12.0

7dc7402

OCA-git-bot and others added 20 commits July 1, 2025 19:06

[UPD] README.rst

cb5ed47

[MIG] website_google_tag_manager: Migration to 13.0

f1d70f6

[MIG] website_google_tag_manager to 13.0

c641259

[MIG][website_google_tag_manager]: Migrate module to 14.0

4a03506

Translated using Weblate (Spanish (Argentina))

0a01b2d

Currently translated at 100.0% (8 of 8 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/es_AR/

Translated using Weblate (French (France))

2b10039

Currently translated at 72.7% (8 of 11 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/fr_FR/

[MIG] website_google_tag_manager: Migration to 15.0

fe41a7d

[IMP] website_google_tag_manager: pre-commit stuff

c46dbf0

[MIG] website_google_tag_manager: Migration to 16.0

6db621a

Translated using Weblate (Italian)

2815067

Currently translated at 12.5% (1 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/

[UPD] README.rst

24922af

Translated using Weblate (Spanish)

d395197

Currently translated at 100.0% (8 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/es/

Translated using Weblate (Italian)

559fc6e

Currently translated at 100.0% (8 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/

[IMP] website_google_tag_manager: pre-commit auto fixes

1b67a5e

[MIG] website_google_tag_manager: Migration to 17.0

fc14e37

Update translation files

3001333

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-17.0/website-17.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_google_tag_manager/

[BOT] post-merge updates

42cb5ca

[IMP] website_google_tag_manager: pre-commit auto fixes

cee4d7d

[MIG] website_google_tag_manager: Migration to 18.0

02d87ed

atchuthan force-pushed the 18.0-mig-website_google_tag_manager branch from 0cb1635 to 02d87ed Compare July 1, 2025 13:36

DavidJForgeFlow approved these changes Jul 23, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jul 23, 2025

OCA-git-bot merged commit 212fad4 into OCA:18.0 Jul 23, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 23, 2025

Uh oh!

[MIG] website_google_tag_manager: Migration to 18.0 #1081

[MIG] website_google_tag_manager: Migration to 18.0 #1081

Uh oh!

Conversation

SodexisTeam commented Dec 24, 2024

Uh oh!

StefanRijnhart commented Jan 31, 2025

Uh oh!

OCA-git-bot commented Jan 31, 2025

Uh oh!

StefanRijnhart commented Jan 31, 2025

Uh oh!

amkarthik commented Jan 31, 2025

Uh oh!

StefanRijnhart commented Jan 31, 2025

Uh oh!

amkarthik commented Feb 4, 2025

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart commented Feb 4, 2025

Uh oh!

desdelinux commented Feb 5, 2025

Uh oh!

OCA-git-bot commented Feb 5, 2025

Uh oh!

JrAdhoc Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

TomAlbrechtQuatra Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart May 8, 2025

Choose a reason for hiding this comment

Uh oh!

atchuthan May 8, 2025

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart May 8, 2025

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart commented May 8, 2025

Uh oh!

pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

atchuthan commented Jul 1, 2025

Uh oh!

StefanRijnhart commented Jul 23, 2025

Uh oh!

OCA-git-bot commented Jul 23, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Jul 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

TomAlbrechtQuatra Apr 29, 2025 •

edited

Loading