mem_tg: fix support for more than 8 memory channels #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sizeof() operator returns the size of an object or type in bytes, not bits. Instead of calculating the number of bits using, e.g., CHAR_BIT * sizeof(), hard-code 64 since it is close to the declaration. This is a prerequisite for HBM support with up to 32 channels. Link: #3137 Fixes: 7bf96dc ("mem_tg test multichannel") Signed-off-by: Peter Colberg <[email protected]>
Pull Request Test Coverage Report for Build 10455767815Details
💛 - Coveralls |
Replace manual memory allocation using new[] and delete[] with std::vector, which avoids unintended memory leaks. Drop unneeded vectors for per-thread promise and tg_exe, which may be stored as local variables inside the lambda function. The lambda is declared as mutable to permit moving the promise. Signed-off-by: Peter Colberg <[email protected]>
This ensures that shared object members are not modified by any thread. Signed-off-by: Peter Colberg <[email protected]>
fpgamatt
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sizeof() operator returns the size of an object or type in bytes, not bits. Instead of calculating the number of bits using, e.g., CHAR_BIT * sizeof(), hard-code 64 since it is close to the declaration.
This is a prerequisite for HBM support with up to 32 channels.
Link: #3137
Fixes: 7bf96dc ("mem_tg test multichannel")