Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem_tg: fix support for more than 8 memory channels #3138

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Commits on Jul 19, 2024

  1. mem_tg: fix support for more than 8 memory channels

    The sizeof() operator returns the size of an object or type in bytes,
    not bits. Instead of calculating the number of bits using, e.g.,
    CHAR_BIT * sizeof(), hard-code 64 since it is close to the declaration.
    
    This is a prerequisite for HBM support with up to 32 channels.
    
    Link: #3137
    Fixes: 7bf96dc ("mem_tg test multichannel")
    Signed-off-by: Peter Colberg <[email protected]>
    pcolberg committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b79e041 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. mem_tg: refactor tg_test() to use std::vector for channels

    Replace manual memory allocation using new[] and delete[] with
    std::vector, which avoids unintended memory leaks. Drop unneeded
    vectors for per-thread promise and tg_exe, which may be stored
    as local variables inside the lambda function. The lambda is
    declared as mutable to permit moving the promise.
    
    Signed-off-by: Peter Colberg <[email protected]>
    pcolberg committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    b006a3e View commit details
    Browse the repository at this point in the history
  2. mem_tg: declare methods called within each thread as const

    This ensures that shared object members are not modified by any thread.
    
    Signed-off-by: Peter Colberg <[email protected]>
    pcolberg committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    0cbe544 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    113b97c View commit details
    Browse the repository at this point in the history