Alpn/v4 #11325
Closed
Alpn/v4 #11325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11325 +/- ##
==========================================
- Coverage 82.47% 82.46% -0.01%
==========================================
Files 934 935 +1
Lines 252270 252311 +41
==========================================
+ Hits 208055 208080 +25
- Misses 44215 44231 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21130 |
jasonish
reviewed
Jun 19, 2024
Comment on lines
+330
to
+331
| alert tls any any -> any any (msg:"TLS ALPN test"; \ | ||
| tls.alpn; content:"http/1.1"; sid:1;) |
There was a problem hiding this comment.
So this would match on client or server? But could be limited with flow:<direction>?
There was a problem hiding this comment.
From detect-tls-alpn.c it looks like that indeed
There was a problem hiding this comment.
yes, this is like other tls keywords
jasonish
approved these changes
Jun 19, 2024
Merged
|
Merged in #11331, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#1924
#11204, rebased, formatting fixed and minimal docs added.
https://redmine.openinfosecfoundation.org/issues/7055
Replaces #11198, adding
tls.alpnkeyword.Example alert for rule
gives
{ "timestamp": "2024-06-01T05:55:05.347344+0000", "flow_id": 373542629722761, "pcap_cnt": 15, "event_type": "alert", "src_ip": "17.248.236.64", "src_port": 443, "dest_ip": "10.84.1.49", "dest_port": 55349, "proto": "TCP", "pkt_src": "wire/pcap", "tx_id": 0, "alert": { "action": "allowed", "gid": 1, "signature_id": 2, "rev": 0, "signature": "", "category": "", "severity": 3 }, "tls": { "subject": "C=US, ST=California, O=Apple Inc., CN=p127-contacts.icloud.com", "issuerdn": "CN=Apple IST CA 2 - G1, OU=Certification Authority, O=Apple Inc., C=US", "subjectaltname": [ "p127-contacts.icloud.com", "p128-contacts.icloud.com", "p129-contacts.icloud.com", "p130-contacts.icloud.com", "p131-contacts.icloud.com", "p132-contacts.icloud.com", "p133-contacts.icloud.com", "p134-contacts.icloud.com", "p135-contacts.icloud.com", "p136-contacts.icloud.com", "p137-contacts.icloud.com", "p138-contacts.icloud.com", "p139-contacts.icloud.com", "p140-contacts.icloud.com", "p141-contacts.icloud.com", "p142-contacts.icloud.com" ], "serial": "4A:96:B3:D3:5F:90:E4:49:E4:D7:ED:85:D4:9E:09:43", "fingerprint": "30:83:82:c5:9d:c2:3b:b4:a9:a6:1a:f2:29:3d:ea:2d:84:1a:19:2e", "sni": "p130-contacts.icloud.com", "version": "TLS 1.2", "notbefore": "2023-10-23T11:42:34", "notafter": "2024-11-21T11:42:33", "client_alpns": [ "h2", "http/1.1" ], "server_alpns": [ "http/1.1" ] }, "app_proto": "tls", "direction": "to_client", "flow": { "pkts_toserver": 8, "pkts_toclient": 7, "bytes_toserver": 1038, "bytes_toclient": 5400, "start": "2024-06-01T05:55:05.283580+0000", "src_ip": "10.84.1.49", "dest_ip": "17.248.236.64", "src_port": 55349, "dest_port": 443 } }