Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/489/20240620/v1 #11331

Merged
merged 6 commits into from
Jun 20, 2024
Merged

next/489/20240620/v1 #11331

merged 6 commits into from
Jun 20, 2024

Conversation

victorjulien
Copy link
Member

victorjulien and others added 6 commits June 20, 2024 06:57
@victorjulien
eve/schema: minor enip reformat
7f474af
@victorjulien
tls: store all ALPN records in the state
0b37654 
For later logging and detection.
@victorjulien
eve/tls: log ALPN for client and server
c79a382 
Part of the extended logging.

Logs `client_alpns` and `server_alpns` arrays in the tls object.

Ticket: OISF#7055.
@victorjulien
eve/schema: update for alpn
869d549
@victorjulien
detect: add tls.alpn keyword
3d05961 
Ticket: OISF#7108.
@catenacyber @victorjulien
detect: remove unused field
dc043d0 
content_inspect_window is used in app-layer-smtp, but
not directly in detect-file-data
@victorjulien victorjulien requested review from jufajardini and a team as code owners June 20, 2024 07:29
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.42%. Comparing base (6256391) to head (dc043d0).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11331   +/-   ##
=======================================
  Coverage   82.41%   82.42%           
=======================================
  Files         934      935    +1     
  Lines      247239   247310   +71     
=======================================
+ Hits       203773   203833   +60     
- Misses      43466    43477   +11
Flag Coverage Δ
fuzzcorpus 60.23% <62.22%> (-0.01%) ⬇️
livemode 18.75% <15.55%> (+<0.01%) ⬆️
pcap 43.78% <61.11%> (-0.02%) ⬇️
suricata-verify 61.37% <91.11%> (+0.01%) ⬆️
unittests 59.31% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

catenacyber
catenacyber approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green
SV is good
Commits are consistent

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21144

@victorjulien victorjulien merged commit dc043d0 into OISF:master Jun 20, 2024
55 checks passed
This was referenced Jun 20, 2024
Closed
Closed
@victorjulien victorjulien deleted the next/489/20240620/v1 branch June 20, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @suricata-qa @catenacyber