Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect prefilter events 6291 v1 #11328

Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/6291
https://redmine.openinfosecfoundation.org/issues/7106

Describe changes:

  • fix missed cases in signature mask for decode events and such
  • add prefilter for decode-event and such

Tested with a random TLPW1-ca1fb1ad30189110cc225620dc537368.pcap with 487089 packets,

time ./src/suricata -c suricata.yaml -k none -r TLPW1-ca1fb1ad30189110cc225620dc537368.pcap -S rules/decoder-events.rules --runmode=single goes down from 12/14 seconds to 8

The second commit is the one with most gains cc @victorjulien

Draft because of last commit : which version is better for prefilter ? last commit or the one before...

Follows on #11303 + #11322

jlucovsky and others added 5 commits June 19, 2024 13:56
Remove unused preprocessor value; exposed by compilation warning
and use SIG_MASK_REQUIRE_ENGINE_EVENT
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (6256391) to head (251762e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11328      +/-   ##
==========================================
- Coverage   82.41%   82.39%   -0.02%     
==========================================
  Files         934      934              
  Lines      247239   247266      +27     
==========================================
- Hits       203773   203746      -27     
- Misses      43466    43520      +54     
Flag Coverage Δ
fuzzcorpus 60.22% <33.33%> (-0.03%) ⬇️
livemode 18.75% <26.66%> (+<0.01%) ⬆️
pcap 43.73% <26.66%> (-0.06%) ⬇️
suricata-verify 61.36% <33.33%> (+0.01%) ⬆️
unittests 59.31% <26.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21139

@catenacyber
Copy link
Contributor Author

Continued in #11366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants