-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Detect integers 7889 v8 #14071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Detect integers 7889 v8 #14071
Conversation
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14071 +/- ##
==========================================
- Coverage 84.45% 84.44% -0.01%
==========================================
Files 1013 1012 -1
Lines 271927 271618 -309
==========================================
- Hits 229662 229375 -287
+ Misses 42265 42243 -22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
} | ||
|
||
*id = pid; | ||
*id = ntohs(pid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: SCNtohs
I see the codebase isn't fully clean, so I wonder if we still need it. It was added a long time ago to work around some windows issue.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7889
Describe changes:
>=
, hexadecimal notation, etc..Still one left to do :
ip_proto
SV_BRANCH=OISF/suricata-verify#2692
#14043 with needed rebase