Skip to content

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7889

Describe changes:

  • Move a bunch of keywords to using generic integers framework, allowing negation, >=, hexadecimal notation, etc..

Still one left to do : ip_proto

SV_BRANCH=OISF/suricata-verify#2692

#14043 with needed rebase

Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 85.50725% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.44%. Comparing base (a1613fe) to head (5909a64).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14071      +/-   ##
==========================================
- Coverage   84.45%   84.44%   -0.01%     
==========================================
  Files        1013     1012       -1     
  Lines      271927   271618     -309     
==========================================
- Hits       229662   229375     -287     
+ Misses      42265    42243      -22     
Flag Coverage Δ
fuzzcorpus 63.35% <67.76%> (-0.06%) ⬇️
livemode 19.49% <5.92%> (+0.11%) ⬆️
pcap 44.90% <17.10%> (+0.09%) ⬆️
suricata-verify 65.33% <51.65%> (+0.05%) ⬆️
unittests 59.45% <63.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}

*id = pid;
*id = ntohs(pid);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: SCNtohs

I see the codebase isn't fully clean, so I wonder if we still need it. It was added a long time ago to work around some windows issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants