-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Draft] main/options: Limit verbose option count #14183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Issue: 7389 Continue to recognize multiple 'v' specifications upto the maximum recognized. The maximum recognized is the number of slots between the NOTICE and CONFIG levels.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14183 +/- ##
==========================================
+ Coverage 84.18% 84.20% +0.02%
==========================================
Files 1013 1013
Lines 262231 262237 +6
==========================================
+ Hits 220747 220805 +58
+ Misses 41484 41432 -52
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| if (suri->verbose < VERBOSE_MAX) | ||
| suri->verbose++; | ||
| else if (!ignore_extra) { | ||
| SCLogNotice("extraneous verbose option(s) ignored"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat word selection :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debian 11 was failing, re-ran it.
Hmm, still failing. One of the checked config options isn't there for this build, maybe?
|
Information: QA ran without warnings. Pipeline = 28126 |
catenacyber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
===> bug-7389: Sub test #1: FAIL : grep "Suricata-Main.*Config:" suricata.log | grep -v -e "Core dump size" -e "Landlock" -e "RWX pages" | wc -l | xargs
PASSED: 2056
FAILED: 1
SKIPPED: 68
I guess the SV test needs to be as simple as possible with just a log line that is added in verbose mode whatever the OS/arch/etc...
Yes .... that's what I was thinking as well for more determinism, something like |
|
Continued in #14267 |
Continuation of #14176
Issue: 7389
Continue to recognize multiple 'v' specifications upto the maximum recognized. The maximum recognized is the number of slots between the NOTICE and CONFIG levels.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7389
Describe changes:
-vcommand line usages.Update:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2723
SU_REPO=
SU_BRANCH=