Skip to content

Conversation

@jlucovsky
Copy link
Contributor

Continuation of #14176

Issue: 7389

Continue to recognize multiple 'v' specifications upto the maximum recognized. The maximum recognized is the number of slots between the NOTICE and CONFIG levels.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7389

Describe changes:

  • Ignore extra -v command line usages.
    Update:
  • New PR as s-v tests have been updated.

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=OISF/suricata-verify#2723
SU_REPO=
SU_BRANCH=

Issue: 7389

Continue to recognize multiple 'v' specifications upto the maximum
recognized. The maximum recognized is the number of slots between the
NOTICE and CONFIG levels.
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.20%. Comparing base (a16e87b) to head (eb15dc3).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14183      +/-   ##
==========================================
+ Coverage   84.18%   84.20%   +0.02%     
==========================================
  Files        1013     1013              
  Lines      262231   262237       +6     
==========================================
+ Hits       220747   220805      +58     
+ Misses      41484    41432      -52     
Flag Coverage Δ
fuzzcorpus 63.39% <0.00%> (+<0.01%) ⬆️
livemode 18.71% <66.66%> (+<0.01%) ⬆️
pcap 44.64% <0.00%> (+0.04%) ⬆️
suricata-verify 64.86% <100.00%> (+0.01%) ⬆️
unittests 59.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

if (suri->verbose < VERBOSE_MAX)
suri->verbose++;
else if (!ignore_extra) {
SCLogNotice("extraneous verbose option(s) ignored");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat word selection :D

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debian 11 was failing, re-ran it.

Hmm, still failing. One of the checked config options isn't there for this build, maybe?

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 28126

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

===> bug-7389: Sub test #1: FAIL : grep "Suricata-Main.*Config:" suricata.log | grep -v -e "Core dump size" -e "Landlock" -e "RWX pages" | wc -l | xargs

PASSED:  2056
FAILED:  1
SKIPPED: 68

I guess the SV test needs to be as simple as possible with just a log line that is added in verbose mode whatever the OS/arch/etc...

@jlucovsky
Copy link
Contributor Author

===> bug-7389: Sub test #1: FAIL : grep "Suricata-Main.*Config:" suricata.log | grep -v -e "Core dump size" -e "Landlock" -e "RWX pages" | wc -l | xargs

PASSED:  2056
FAILED:  1
SKIPPED: 68

I guess the SV test needs to be as simple as possible with just a log line that is added in verbose mode whatever the OS/arch/etc...

Yes .... that's what I was thinking as well for more determinism, something like
Config: Suricata verbose level set to <x>

@jlucovsky
Copy link
Contributor Author

Continued in #14267

@jlucovsky jlucovsky closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants