Skip to content

Conversation

@jlucovsky
Copy link
Contributor

Continuation of #14183

Issue: 7389

Continue to recognize multiple 'v' specifications upto the maximum recognized. The maximum recognized is the number of slots between the NOTICE and CONFIG levels.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7389

Describe changes:

  • Ignore extra -v command line usages.

Update:

  • New PR as s-v tests have been updated.
  • Simplified detection as the previous method used by s-v relied on counting messages, that was very platform dependent.

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=OISF/suricata-verify#2723
SU_REPO=
SU_BRANCH=

Issue: 7389

Continue to recognize multiple 'v' specifications up to the maximum
recognized. The maximum recognized is the number of slots between the
NOTICE and CONFIG levels.
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (bb1ed16) to head (0096102).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14267      +/-   ##
==========================================
- Coverage   84.14%   84.14%   -0.01%     
==========================================
  Files        1013     1013              
  Lines      262354   262362       +8     
==========================================
- Hits       220764   220758       -6     
- Misses      41590    41604      +14     
Flag Coverage Δ
fuzzcorpus 63.32% <0.00%> (-0.01%) ⬇️
livemode 18.72% <72.72%> (+0.01%) ⬆️
pcap 44.58% <9.09%> (-0.06%) ⬇️
suricata-verify 64.85% <100.00%> (-0.05%) ⬇️
unittests 59.19% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_suri_time.

Pipeline = 28326

@jlucovsky jlucovsky marked this pull request as ready for review November 6, 2025 15:14
Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work,

CI : ✅ :-)
Code : good
Commits segmentation : ok
Commit messages : I feel like the bug fixed does not appear in the commit message (that vvvvvvvv is/was not so verbose)
Git ID set : looks fine for me
CLA : you already contributed
Doc update : not needed
Redmine ticket : ok, set target version to 9beta1
Rustfmt : no rust
Tests : cool
Dependencies added: none

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 28428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants