Skip to content

Conversation

romanett
Copy link
Contributor

Proposed changes

This pull request updates the process for generating temporary application certificates to ensure that domain names from the existing certificate are preserved when regenerating the private key.

Related Issues

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklistt

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

…gningRequestAsync with parameter regeneratePrivateKey = true
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the CreateSigningRequestMethod where domain names and application name were being lost when regenerating the private key for temporary application certificates.

  • Extract domain names from existing certificate before regeneration
  • Pass domain names to the certificate generation method
  • Include application name in the certificate builder

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.63%. Comparing base (2bee7e1) to head (ce235ee).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
- Coverage   57.72%   57.63%   -0.10%     
==========================================
  Files         365      365              
  Lines       79419    79421       +2     
  Branches    13865    13865              
==========================================
- Hits        45845    45774      -71     
- Misses      29325    29388      +63     
- Partials     4249     4259      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett romanett self-assigned this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants