Skip to content

[Server] Include domains and applicationName in ServerCertificate for CreateSigningRequest Method with parameter regeneratePrivateKey = true #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Server] Include domains and applicationName in ServerCertificate for CreateSigningRequest Method with parameter regeneratePrivateKey = true #3263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b695e1e
Include domains and applicationName in ServerCertificate for CreateSi…
romanett Oct 13, 2025
ce235ee
Update Libraries/Opc.Ua.Server/Configuration/ConfigurationNodeManager.cs
romanett Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Libraries/Opc.Ua.Server/Configuration/ConfigurationNodeManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,10 +826,13 @@ private async ValueTask<CreateSigningRequestMethodStateResult> CreateSigningRequ
X509Certificate2 certWithPrivateKey;
if (regeneratePrivateKey)
{
IList<string> domainNames = X509Utils.GetDomainsFromCertificate(existingCertIdentifier.Certificate);

certWithPrivateKey = GenerateTemporaryApplicationCertificate(
certificateTypeId,
certificateGroup,
subjectName);
subjectName,
domainNames);
}
else
{
Expand Down Expand Up @@ -867,12 +870,13 @@ private async ValueTask<CreateSigningRequestMethodStateResult> CreateSigningRequ
private X509Certificate2 GenerateTemporaryApplicationCertificate(
NodeId certificateTypeId,
ServerCertificateGroup certificateGroup,
string subjectName)
string subjectName,
IList<string> domainNames)
{
X509Certificate2 certificate;

ICertificateBuilder certificateBuilder = CertificateFactory
.CreateCertificate(m_configuration.ApplicationUri, null, subjectName, null)
.CreateCertificate(m_configuration.ApplicationUri, m_configuration.ApplicationName, subjectName, domainNames)
.SetNotBefore(DateTime.Today.AddDays(-1))
.SetNotAfter(DateTime.Today.AddDays(14));

Expand Down
Loading