storage: clone_device: increase dd block size#2650
Merged
IsaacJT merged 2 commits intoOSInside:mainfrom Sep 24, 2024
Merged
Conversation
Increasing the block size used for dd reduces the time needed to clone a device. Signed-off-by: Isaac True <isaac@is.having.coffee>
Collaborator
|
@IsaacJT a good change, thanks. Can you adapt the corresponding unit test too ? Thanks |
Signed-off-by: Isaac True <isaac@is.having.coffee>
Collaborator
Author
|
@schaefi done :) |
schaefi
approved these changes
Sep 23, 2024
Collaborator
schaefi
left a comment
schaefi
left a comment
There was a problem hiding this comment.
Thanks, looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
ddreduces the time needed to clone a device.ddoperations take a long time, especially on cross-architecture builds usingkiwi-boxed-plugin. This should help to speed it up a bit.