-
Notifications
You must be signed in to change notification settings - Fork 34
ABFE protocol #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ABFE protocol #1045
Changes from 27 commits
Commits
Show all changes
138 commits
Select commit
Hold shift + click to select a range
5d0b683
Towards ABFE protocol
IAlibay 22fbc37
Add base code for settings
IAlibay e1ef18c
Fix up the units a bit
IAlibay 158ce40
Deal with the restraint addition
IAlibay deac61d
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 2dd883a
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 67abff1
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 06f84c5
Add various fixes
IAlibay 8506db2
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 6ecec87
some QoL updates
IAlibay f5369c6
Fix a few things with the restraint addition
IAlibay 0e93e00
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 6f5a4e0
fix regex match test
IAlibay 9f1cc46
Fix the case where we don't have a restraint parameter
IAlibay 0d32568
Enforce the periodic box when getting state to avoid NaNs
IAlibay 4aa6151
Fix up some protocol results things
IAlibay c0d3d58
Add some tests and validation
IAlibay 7db8ac6
Merge branch 'omm-restraints' into abfe_protocol
IAlibay a856403
Some reformatting
IAlibay a28cc59
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 6d0a51d
fix return type hint
IAlibay ecad789
Add test for complex equil output indices
IAlibay d901204
Allow generation of results for ABFEs
IAlibay 86fc509
add settings_cls
IAlibay f976de0
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 84a932b
Update openfe/protocols/restraint_utils/settings.py
IAlibay 5a59f08
Bad things
IAlibay 617b8fe
Fix the restraints to be the right way around
IAlibay 3abe329
lint file, add restraint_geom return
IAlibay b4b0f33
Add rest geom return
IAlibay 56045c9
Fix up things
IAlibay f219492
Add protocol results for testing and also add geometry to results object
IAlibay d5ac4e0
Add tokenization tests
IAlibay 8258f66
add protocol results tests
IAlibay e1a5645
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 22038f4
Remove None guard
IAlibay d24605f
revert random guard
IAlibay 8012625
fixing pbc handling and the solvent unit
IAlibay befb5d7
Add a comment
IAlibay b626f53
fix
IAlibay be2de12
separate solvation settings for complex and solvent
hannahbaumann 302eb2b
Update openfe/protocols/openmm_afe/equil_binding_afe_method.py
hannahbaumann 984a501
Merge branch 'main' into abfe_protocol
hannahbaumann d17fa4f
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 52076d0
max on frc_const check
IAlibay 2fab254
try sanitizing molecules
IAlibay eba3d43
Add missing return
IAlibay 81823c0
Merge branch 'omm-restraints' into abfe_protocol
IAlibay 814f468
min not max
IAlibay b051600
Merge branch 'omm-restraints' into abfe_protocol
IAlibay e113e7c
Make the reporter write the last frame
IAlibay 08b28dc
fix benzene solvent test
IAlibay 5ee7c73
Update tests
IAlibay 2533cef
Merge branch 'main' into abfe_protocol
IAlibay 614edc1
Merge branch 'abfe_protocol' of github.com:OpenFreeEnergy/openfe into…
IAlibay 8ed6084
update lambdas to list[float]
IAlibay 6982106
Merge branch 'omm-restraints' into abfe_protocol
IAlibay f84d72a
Fix the get states call
IAlibay 96e9325
fix units
IAlibay 3557ffe
black after isort
IAlibay 3c7de18
fix tests
IAlibay cc6d112
fix mypy
IAlibay f69daf9
backport Mike's fix
IAlibay 9f09b85
Merge branch 'main' into abfe_protocol
IAlibay 780671c
Merge branch 'main' into abfe_protocol
hannahbaumann 626c9d0
Merge branch 'main' into abfe_protocol
IAlibay 274c258
Enable anchor finding strategy in abfe protocol
IAlibay cb11dc5
Merge branch 'main' into abfe_protocol
IAlibay 4c72787
Merge branch 'main' into abfe_protocol
hannahbaumann 864f10c
Merge branch 'main' into abfe_protocol
hannahbaumann a157b57
Add ABFE protocol docs (#1507)
hannahbaumann 301b381
Merge branch 'main' into abfe_protocol
IAlibay 919f125
Merge branch 'main' into abfe_protocol
hannahbaumann 57f694d
Merge branch 'main' into abfe_protocol
hannahbaumann 42b87aa
Merge branch 'main' into abfe_protocol
IAlibay 127468a
Some formatting, duecredit tests
IAlibay 15bdfbc
some fixes
IAlibay 9b1507a
some prep for net charge checks
IAlibay 9df87d5
Merge branch 'main' into abfe_protocol
IAlibay 16f2b63
some validation stuff
IAlibay a867d39
Fix up settings and validation things
IAlibay 6088267
format settings
IAlibay d30b574
format the lambda schedules
IAlibay 47ab5a7
Merge branch 'main' into abfe_protocol
IAlibay 8335198
Deal with some validation stuff
IAlibay 97ffb2e
Merge branch 'abfe_protocol' of github.com:OpenFreeEnergy/openfe into…
IAlibay 2119ce5
fix up protocol results tests
IAlibay 07e0aa7
Merge branch 'main' into abfe_protocol
IAlibay 849365b
typing thing
IAlibay 03757e9
Add more returns to the debug dictionary
IAlibay 3fca3c1
Add gather test
IAlibay 139411b
Add tagging test
IAlibay 8765e60
stop duplicating execute everywhere
IAlibay 45b3a99
Add check for virtual sites & fail if no reassign
IAlibay b5eefa7
move timestep validation up to validate
IAlibay 8669e27
Merge branch 'main' into abfe_protocol
IAlibay 0580dd1
Add unit tagging tests
IAlibay 1c8386a
Add base dry run test
IAlibay 07577fe
Add energy checks
IAlibay c133006
reformat a few things
IAlibay 3032da3
Merge branch 'main' into abfe_protocol
IAlibay e199baa
Add slow extra dry run test
IAlibay 5b1a65e
Add energy tests
IAlibay a394fa9
Apply suggestion from @hannahbaumann
IAlibay 77e35cb
typo
IAlibay 8d7cd64
remove extra prints
IAlibay 5bf0144
deal with typo
IAlibay 07d922c
fix septop test with renamed fixture
IAlibay 156e73f
Various fixes and some slow tests
IAlibay df219c6
Merge branch 'main' into abfe_protocol
IAlibay a68f062
Add news item
IAlibay ba1c807
remove debug shim
IAlibay d935551
reverse the restraint lambda windows
IAlibay 7fe2712
Update openfe/protocols/openmm_afe/equil_binding_afe_method.py
IAlibay d20fffd
Update openfe/protocols/openmm_afe/equil_binding_afe_method.py
IAlibay 4be91e0
Update openfe/tests/protocols/openmm_abfe/test_abfe_energies.py
IAlibay b9d37d2
Change how we combine corrections
IAlibay 2bdb6a9
Merge branch 'abfe_protocol' of github.com:OpenFreeEnergy/openfe into…
IAlibay 9f802d1
Address some review comments
IAlibay c2bff25
Add an extra note for the solvent lambda settings
IAlibay d7e0da9
Merge branch 'main' into abfe_protocol
IAlibay 3fb1036
try to make myppy happy
IAlibay a29dbc0
you happy now mypy?
IAlibay acd1f6b
And again...
IAlibay b25f86e
Add net charge check test
IAlibay ec04f3a
remove early termination
IAlibay 23ed15e
Merge branch 'main' into abfe_protocol
IAlibay 6b87bab
Merge branch 'main' into abfe_protocol
IAlibay fa02671
fix tests
IAlibay a174ef2
fix restraints
IAlibay 5fff298
fix settings validation for lambdas
IAlibay 9d22909
update results
IAlibay ef634a0
Merge branch 'main' into abfe_protocol
IAlibay 7cec9e2
Update for new settings
IAlibay ec5ecd2
Merge branch 'main' into abfe_protocol
IAlibay 9765bf1
Merge branch 'main' into abfe_protocol
IAlibay 8e1b2ee
Update openfe/protocols/openmm_afe/equil_afe_settings.py
IAlibay 5c8ef53
Merge branch 'main' into abfe_protocol
IAlibay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.