Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct mapping code from csv to json for land use #117

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

diem-ai
Copy link
Member

@diem-ai diem-ai commented Jun 15, 2021

This is a correction where each complex object of data source, geo component, emission is written in one separate line in json file.

@S-AI-F S-AI-F requested a review from bouffan June 16, 2021 13:04
@S-AI-F S-AI-F added the data-mapping This issue or pull request already exists label Jun 16, 2021
@S-AI-F S-AI-F linked an issue Jun 16, 2021 that may be closed by this pull request
Copy link
Member

@bouffan bouffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diem-ai !

I just finished seeing the file and I have just some minor comments before approving!

First, there is a special geo-component/scale for continents that is ''country_group". In the current mapped file, the scale selected for continents is "country"

So far the name for the continent is used in "id" and the "type" is set to alpha3
ex for America: "identifier": {"id": "America", "type": "alpha3"}
But in this case, the type should be set to "name"

Finally, it seems that there is only one sector mapped in the file. If you want to map all sectors, if you want you can have examples of notebooks that does that for the mapped data that have been merged into main (oecd, wri, primap, gcp)

@diem-ai
Copy link
Member Author

diem-ai commented Jun 18, 2021

Hi

Hi @diem-ai !

I just finished seeing the file and I have just some minor comments before approving!

First, there is a special geo-component/scale for continents that is ''country_group". In the current mapped file, the scale selected for continents is "country"

So far the name for the continent is used in "id" and the "type" is set to alpha3
ex for America: "identifier": {"id": "America", "type": "alpha3"}
But in this case, the type should be set to "name"

Finally, it seems that there is only one sector mapped in the file. If you want to map all sectors, if you want you can have examples of notebooks that does that for the mapped data that have been merged into main (oecd, wri, primap, gcp)

Thanks for your comments.

  • I'll correct the type of geo identifier object by replace "alpha3" by "name"
  • There is only one sector, lucf, which produces co2 gas in that dataset.

@diem-ai
Copy link
Member Author

diem-ai commented Jun 24, 2021

Hi,
The correction is done. Please proceed the Merge request.

diem-ai added 2 commits June 24, 2021 18:58
… countries; a modification of json file creation: appending the new json objects into the current json file
@diem-ai
Copy link
Member Author

diem-ai commented Jun 24, 2021

Hi,

This Pull request covers:

  • A new notebook that processes raw time series fossil fuel by countries. The purpose is to enrich the variety of sectors for cdiac.
  • A modification of json file creation: Appending the new json object into the current file if it exists so that we can have only one mapped cdiac file at the end no matter how many notebooks (for cdiac) were executed.

@bouffan
Copy link
Member

bouffan commented Jun 29, 2021

@diem-ai Hi Diem !

I just finished watching the mapping. I have just two comments for the mapping!

  1. in the current version, you use geo_scale = "country" for all entries of the data. However, some of the entries are continents or groups of countries. In this case, the geo_scale should be set to "country_group"

  2. I have a question about the second notebook mapping (fossil_fuel_nation). In this notebook, some sectors are mapped towards the same ogs sector even though they do not have the same origin sector name. @S-AI-F suggested to wait after the demo day so that we can discuss together how to treat these cases !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-mapping This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDIAC- Mapping with OGS integration data model
3 participants