-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct mapping code from csv to json for land use #117
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @diem-ai !
I just finished seeing the file and I have just some minor comments before approving!
First, there is a special geo-component/scale for continents that is ''country_group". In the current mapped file, the scale selected for continents is "country"
So far the name for the continent is used in "id" and the "type" is set to alpha3
ex for America: "identifier": {"id": "America", "type": "alpha3"}
But in this case, the type should be set to "name"
Finally, it seems that there is only one sector mapped in the file. If you want to map all sectors, if you want you can have examples of notebooks that does that for the mapped data that have been merged into main (oecd, wri, primap, gcp)
Hi
Thanks for your comments.
|
Hi, |
… countries; a modification of json file creation: appending the new json objects into the current json file
Hi, This Pull request covers:
|
@diem-ai Hi Diem ! I just finished watching the mapping. I have just two comments for the mapping!
|
This is a correction where each complex object of data source, geo component, emission is written in one separate line in json file.