scheduler/job.c: Fix extensive logging in scheduler #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on currently unknown trigger scheduler sometimes sets JobHistoryUpdate into past, which causes `select()` to timeout after one second. It happens when `job->file_time` of a job without files to remove gets assigned to `JobHistoryUpdate`. If we check for `job->num_files` and assign the `job->file_time` only if there are any, we will fix extensive logging (and unneeded cupsd execution) in various places, e.g. cleaning jobs, expiring subscriptions, deleting temporary queues... Fixes OpenPrinting#604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on currently unknown trigger scheduler sometimes sets JobHistoryUpdate into past, which causes
select()to timeout after one second.It happens when
job->file_timeof a job without files to remove gets assigned toJobHistoryUpdate. If we check forjob->num_filesand assign thejob->file_timeonly if there are any, we will fix extensive logging (and unneeded cupsd execution) in various places, e.g. cleaning jobs, expiring subscriptions, deleting temporary queues...Fixes #604