Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler/job.c: Fix extensive logging in scheduler #767

Merged
merged 1 commit into from
Jul 27, 2023
Merged

scheduler/job.c: Fix extensive logging in scheduler #767

merged 1 commit into from
Jul 27, 2023

Commits on Jul 27, 2023

  1. scheduler/job.c: Fix extensive logging in scheduler 

    Based on currently unknown trigger scheduler sometimes sets
JobHistoryUpdate into past, which causes `select()` to timeout after one
second.

It happens when `job->file_time` of a job without files to remove gets
assigned to `JobHistoryUpdate`. If we check for `job->num_files` and
assign the `job->file_time` only if there are any, we will fix extensive
logging (and unneeded cupsd execution) in various places, e.g. cleaning
jobs, expiring subscriptions, deleting temporary queues...

Fixes OpenPrinting#604
    @zdohnal
    zdohnal committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    541f72d View commit details
    Browse the repository at this point in the history