Dark mode: drop dark variants #2270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hannahiss
reviewed
Sep 28, 2023
| </div> | ||
| </div> | ||
| {{< /example >}} | ||
| Add `data-bs-theme="dark"` to the `.accordion` or any ancestor element to enable a component-specific color mode. [Learn more about our color modes]({{< docsref "/customize/color-modes" >}}). |
Member
There was a problem hiding this comment.
Note for later: we will have to check wether users need to add a background in addition to theme, and if so, mention it there. Same for other components
julien-deramond
force-pushed
the
main-jd-dark-mode-drop-dark-variants
branch
from
bb078d6 to
36cb3f0
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-drop-dark-variants
branch
from
36cb3f0 to
70c6f34
Compare
|
|
||
| $mark-padding: 0 .1875em !default; // Boosted mod | ||
| $mark-color: $white !default; // Boosted mod: instead of `$body-color` | ||
| $mark-bg: $black !default; // Boosted mod: instead of `$yellow-100` |
Member
There was a problem hiding this comment.
[Out of PR] We might not need to precise it's a Boosted mod since we are already inside one (since l.719)
Member
|
As dark variants, we might remove as well:
|
Co-authored-by: Louis-Maxime Piton <[email protected]>
Co-authored-by: Louis-Maxime Piton <[email protected]>
Co-authored-by: Louis-Maxime Piton <[email protected]>
Member
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
Two small questions.
Co-authored-by: Louis-Maxime Piton <[email protected]>
Co-authored-by: Louis-Maxime Piton <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining retro compatibility with dark variants would cause too many issues:
So this PR:
.accordion-dark.dropdown-menu-darkare kept for now since Bootstrap still has it in its documentation. This is also linked to the topics: are headers supposed to usedata-bs-theme="dark"or not. Not in the scope of this PR.button-varianthas its last parameter removed since used only to handle.btn-inverse.btn-inverse.btn-close-whitein the documentation as it is deprecated by Bootstrap but kept it in the code for retro compatibility.navbar-darkinside its DOM... Also linked to the headers, but hope it's gonna work without.navbar-dark. Let's see when we'll develop this component.navbar-darkare kept for now since Bootstrap still has it in its documentation. This is linked to the topic: are headers supposed to usedata-bs-theme="dark"or not. Not in the scope of this PR..btn-close-whitealso still available in Bootstrap