Skip to content

Fix color of default loading button in high contrast light mode #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2025
Merged

Fix color of default loading button in high contrast light mode #18

merged 3 commits into from
Jun 12, 2025

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Jun 10, 2025 •
edited by ludovic35
Loading

Related issues

Orange-OpenSource/ouds-ios#437

Description

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I checked I am using the last version of OUDS iOS library
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp pylapp requested a review from ludovic35 as a code owner June 10, 2025 14:38
@pylapp pylapp mentioned this pull request Jun 10, 2025
Merged
13 tasks
@pylapp
Copy link
Member Author

pylapp commented Jun 10, 2025 •
edited
Loading

@ludovic35 The PR of the library should be reviewed and merge after: Orange-OpenSource/ouds-ios#708

Commit message:

fix: default loading button on high contrast light mode (Orange-OpenSource/ouds-ios#437) (#18)

@pylapp pylapp force-pushed the 437-buga11y-insufficient-contrast-of-the-orange-spinner-for-button-in-loading-state branch from 7e58543 to 88cae5a Compare June 11, 2025 09:02
pylapp and others added 3 commits June 12, 2025 15:22
@pylapp @ludovic35
test: update snapshots tests (Orange-OpenSource/ouds-ios#437)
a20c478 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
chore(deps): point to Orange-OpenSource/ouds-ios#437 Git branch for S…
2cf6241 
…wift package

This helps to make tests and reviews, shuld be fixed with package branch is merged

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@ludovic35
refacto: use the last develop version
2104ac5
@ludovic35 ludovic35 force-pushed the 437-buga11y-insufficient-contrast-of-the-orange-spinner-for-button-in-loading-state branch from 88cae5a to 2104ac5 Compare June 12, 2025 13:36
@ludovic35 ludovic35 merged commit c5e9eaf into develop Jun 12, 2025
15 of 16 checks passed
@ludovic35 ludovic35 deleted the 437-buga11y-insufficient-contrast-of-the-orange-spinner-for-button-in-loading-state branch June 12, 2025 13:49
ludovic35 added a commit that referenced this pull request Jun 12, 2025
@pylapp @ludovic35
fix: default loading button on high contrast light mode (Orange-OpenS…
061cb65 
…ource/ouds-ios#437) (#18)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic PINEL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 ludovic35 approved these changes

Assignees

@ludovic35 ludovic35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pylapp @ludovic35