Skip to content

[#437] Fix color of default loading button in high contrast light mode #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Jun 10, 2025

Related issues

#437

Description

In default loading button change color if high contrast light mode

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp
Copy link
Member Author

pylapp commented Jun 10, 2025

@ludovic35 The PR on the demo app should be reviewed and merged before: Orange-OpenSource/ouds-ios-design-system-toolbox#18

Commit message:

fix: default loading button on high contrast light mode (#437) (#708)

@pylapp pylapp changed the title [#437] Color of default loading button in high contrast light mode [#437] Fix color of default loading button in high contrast light mode Jun 10, 2025
ludovic35
ludovic35 previously approved these changes Jun 11, 2025
@pylapp pylapp force-pushed the 437-buga11y-insufficient-contrast-of-the-orange-spinner-for-button-in-loading-state branch from 81afec8 to 2b6d40e Compare June 12, 2025 09:13
@ludovic35 ludovic35 merged commit 8a1ddf3 into develop Jun 12, 2025
13 of 14 checks passed
@ludovic35 ludovic35 deleted the 437-buga11y-insufficient-contrast-of-the-orange-spinner-for-button-in-loading-state branch June 12, 2025 09:44
pylapp added a commit that referenced this pull request Jun 12, 2025
pylapp added a commit that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][a11y] Insufficient contrast of the orange spinner for button in loading state
2 participants