Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python struct for deserializing #13

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

benemer
Copy link
Member

@benemer benemer commented Mar 28, 2024

The loading is slow for HeLiPR, especially for the Aeva and Ouster data. Using Python's struct is a bit faster than numpy's from_file. This improves the runtime from 3.8 Hz to 4.6 Hz for Aeva and from 2.4 Hz to 3.3 Hz for Ouster.

Copy link
Contributor

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice ! Waiting on @saurabh1002 now

@nachovizzo nachovizzo merged commit 482ca7a into main Apr 3, 2024
6 checks passed
@nachovizzo nachovizzo deleted the benedikt/faster_helipr_reading branch April 3, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants