Skip to content

Commit 0749b04

Browse files
pavel-kirienkoLorenzMeier
authored andcommitted
Fixed stack overflow in UAVCAN process (#4643)
* Increased uavcan stack size; the old value of 1800 was insufficient * Removed a misleading warning message from uavcan servers initialization
1 parent 0902401 commit 0749b04

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/modules/uavcan/uavcan_main.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ class UavcanNode : public device::CDev
103103
*/
104104

105105
static constexpr unsigned RxQueueLenPerIface = FramePerMSecond * PollTimeoutMs; // At
106-
static constexpr unsigned StackSize = 1800;
106+
static constexpr unsigned StackSize = 2400;
107107

108108
public:
109109
typedef uavcan_stm32::CanInitHelper<RxQueueLenPerIface> CanInitHelper;

src/modules/uavcan/uavcan_servers.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,6 @@ void UavcanServers::unpackFwFromROMFS(const char* sd_path, const char* romfs_pat
923923

924924
DIR* const romfs_dir = opendir(romfs_path);
925925
if (!romfs_dir) {
926-
warnx("base: couldn't open %s", romfs_path);
927926
return;
928927
}
929928

0 commit comments

Comments
 (0)