Skip to content

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Apr 19, 2025

Renovate didn't open a PR, so did it manually.

Suggested commit message:

Upgrade Error Prone 2.37.0 -> 2.38.0 (#1649)

Resolves #1646.

See:
- https://github.com/google/error-prone/releases/tag/v2.38.0
- https://github.com/google/error-prone/compare/v2.37.0...v2.38.0
- https://github.com/PicnicSupermarket/error-prone/compare/v2.37.0-picnic-1...v2.38.0-picnic-1

@Stephan202 Stephan202 added this to the 0.23.0 milestone Apr 19, 2025
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member Author

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context.

pom.xml Outdated
Comment on lines 1647 to 1655
<!-- XXX: This dependency is incompatible with
Error Prone 2.38.0+. Re-enabled it once it is
compatible again.
<path>
<groupId>com.github.lhotari</groupId>
<artifactId>reactor-error-prone</artifactId>
<version>${version.reactor-error-prone}</version>
</path>
-->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to drop this in #1650. PRs can be merged in either order; I'll resolve the conflict.

Comment on lines -1931 to -1895
<!-- We don't target JDK 7. -->
-Xep:Java7ApiChecker:OFF
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check no longer exists.

-XepOpt:CheckReturnValue:CheckAllMethods=true -->
<!-- XXX: Consider renaming flagged types
instead. -->
-XepOpt:ConstantExpressions:ConsiderAllMethodsPure=true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled to maximize opportunities for the check to flag things.

-XepOpt:NullAway:CheckOptionalEmptiness=true
-XepOpt:NullAway:JSpecifyMode=true
-XepOpt:Nullness:Conservative=false
-XepOpt:StatementSwitchToExpressionSwitch:EnableDirectConversion=true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now the default.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 merged commit 1e149cc into master Apr 19, 2025
17 checks passed
@Stephan202 Stephan202 deleted the renovate/version.error-prone-orig branch April 19, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants