-
Notifications
You must be signed in to change notification settings - Fork 46
Upgrade Error Prone 2.37.0 -> 2.38.0 #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some context.
pom.xml
Outdated
<!-- XXX: This dependency is incompatible with | ||
Error Prone 2.38.0+. Re-enabled it once it is | ||
compatible again. | ||
<path> | ||
<groupId>com.github.lhotari</groupId> | ||
<artifactId>reactor-error-prone</artifactId> | ||
<version>${version.reactor-error-prone}</version> | ||
</path> | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to drop this in #1650. PRs can be merged in either order; I'll resolve the conflict.
<!-- We don't target JDK 7. --> | ||
-Xep:Java7ApiChecker:OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check no longer exists.
-XepOpt:CheckReturnValue:CheckAllMethods=true --> | ||
<!-- XXX: Consider renaming flagged types | ||
instead. --> | ||
-XepOpt:ConstantExpressions:ConsiderAllMethodsPure=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabled to maximize opportunities for the check to flag things.
-XepOpt:NullAway:CheckOptionalEmptiness=true | ||
-XepOpt:NullAway:JSpecifyMode=true | ||
-XepOpt:Nullness:Conservative=false | ||
-XepOpt:StatementSwitchToExpressionSwitch:EnableDirectConversion=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📈
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
|
Looks good. No mutations were possible for these changes. |
Renovate didn't open a PR, so did it manually.
Suggested commit message: