Skip to content

[GH-238] Fixed HiC map annotations issue #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

[GH-238] Fixed HiC map annotations issue #241

merged 1 commit into from
Jun 29, 2025

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Jun 29, 2025

PR checklist

  • Contig names not appearing in hi-c heatmap on some browsers #238
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@GallVp GallVp requested a review from ignacio3437 June 29, 2025 23:33
@GallVp GallVp linked an issue Jun 29, 2025 that may be closed by this pull request
Contig names not appearing in hi-c heatmap on some browsers #238
Open
@GallVp
Copy link
Member Author

GallVp commented Jun 29, 2025

Hi @ignacio3437

This fixes it for Chrome. It is still broken on Firefox. Here is the test command for generating a minimal test result,

./main.nf -profile docker -resume --outdir results --input tests/hic/assemblysheet.csv --hic "tests/hic/testdata/HYh1h2_Chr01_6000000_6015000.R{1,2}.fastq.gz"

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fefaa84

+| ✅ 180 tests passed       |+
#| ❔  34 tests were ignored |#
!| ❗  24 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.1
  • Run at 2025-06-29 23:34:50

@GallVp GallVp mentioned this pull request Jun 29, 2025
Open
@GallVp GallVp merged commit 6231724 into dev Jun 29, 2025
6 checks passed
@GallVp GallVp deleted the fix/238 branch June 29, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignacio3437 ignacio3437 Awaiting requested review from ignacio3437

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contig names not appearing in hi-c heatmap on some browsers
1 participant
@GallVp