Skip to content

[GH-247] Sub-workflow FASTA_SEQKIT_REFSORT now works for n-genomes #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

[GH-247] Sub-workflow FASTA_SEQKIT_REFSORT now works for n-genomes #256

merged 1 commit into from
Jul 14, 2025

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Jul 14, 2025

PR checklist

  • [The HiC combination map should be possible for N haplotypes #247] Sub-workflow FASTA_SEQKIT_REFSORT now works for n-genome combinations
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@GallVp GallVp linked an issue Jul 14, 2025 that may be closed by this pull request
The HiC combination map should be possible for N haplotypes #247
Open
@GallVp GallVp requested a review from ignacio3437 July 14, 2025 21:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 44a7278

+| ✅ 180 tests passed       |+
#| ❔  34 tests were ignored |#
!| ❗  24 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.2
  • Run at 2025-07-14 21:25:02

@GallVp GallVp merged commit 81d386f into dev Jul 14, 2025
19 checks passed
@GallVp GallVp deleted the feat/247 branch July 14, 2025 21:34
@ignacio3437
Copy link

Nice one! This is important for future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignacio3437 ignacio3437 Awaiting requested review from ignacio3437

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The HiC combination map should be possible for N haplotypes
2 participants
@GallVp @ignacio3437