fix(linting): fix local npm lint scripts #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also run lint-fix and add the fixed files
nina-py
reviewed
Jun 18, 2024
Comment on lines
-100
to
+101
| "lint-check": "tsc --noEmit && eslint src/**/*.ts{,x}", | ||
| "lint-fix": "tsc --noEmit && eslint src/**/*.ts{,x} --fix", | ||
| "lint-check": "eslint src/**/*.ts{,x}", | ||
| "lint-fix": "eslint src/**/*.ts{,x} --fix", |
There was a problem hiding this comment.
This would have been set up by us manually back in the day AFAIK, perhaps with the ejection from react-scripts and major version update to ESLint this is no longer needed?
nina-py
approved these changes
Jun 18, 2024
katerinachinnappan
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
fix local npm lint scripts
Test Locally
pull down the latest
mainand runnpm run lint-check. for me, this reported one error in a file innode_modules- which is a directory it shouldn't even check. it also does not report the errors that my fix here does.still on the
mainbranch, update thepackage.jsonlint scripts to match the ones in this PR and run them. you should get the correct output (like 80 files needing fixing).Implementation Decisions
does anyone know why we were running
tscbefore the lint scripts? why would we need to compile to only lint.ts(x)files?also - unclear why the files caught here are no being caught by the github linter. other repositories are experiencing similar local/github linting discrepancies - wonder if some downstream package got changed...