Remove token from local_evaluation API call#76
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Optimized local evaluation feature flag handling by removing redundant token parameter and enhancing documentation for API key management.
- Removed unnecessary
tokenparameter from/api/feature_flag/local_evaluationendpoint insrc/PostHog/Api/PostHogApiClient.cs - Added local evaluation setup instructions in
src/PostHog.AspNetCore/README.mdfor development and production environments - Included security guidance for API key management using user secrets and environment variables
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Don't try to read the response body.
haacked
force-pushed
the
haacked/fix-local-evaluation
branch
from
8e6263e to
b9084b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not used nor needed.
Also added some docs on local evaluation.