refactor: Support type checking from cache_for decorator
#26052
+56
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(for better or for worse) or fixing them causes more problems than it solves
tkaemming
changed the title
cache_key decoratorcache_for decorator
tkaemming
changed the title
cache_for decoratorcache_for decorator
tkaemming
commented
Nov 7, 2024
Comment on lines
+72
to
+73
| current_materialized_column_name = materialized_columns.get((property_name, "properties"), None) | ||
| if current_materialized_column_name is not None and current_materialized_column_name != property_name: |
There was a problem hiding this comment.
This has been broken for a while
Comment on lines
+604
to
+606
| posthog/year_in_posthog/year_in_posthog.py:0: error: Item "None" of "dict[Any, Any] | None" has no attribute "get" [union-attr] | ||
| posthog/year_in_posthog/year_in_posthog.py:0: error: Argument 1 to "stats_for_user" has incompatible type "dict[Any, Any] | None"; expected "dict[Any, Any]" [arg-type] | ||
| posthog/year_in_posthog/year_in_posthog.py:0: error: Item "None" of "dict[Any, Any] | None" has no attribute "get" [union-attr] |
There was a problem hiding this comment.
These are already "handled" here and don't want to fix them
posthog/posthog/year_in_posthog/year_in_posthog.py
Lines 130 to 135 in ff2271b
| @@ -333,12 +333,14 @@ ee/billing/billing_manager.py:0: error: Incompatible types in assignment (expres | |||
| posthog/models/property/util.py:0: error: Incompatible type for lookup 'pk': (got "str | int | list[str]", expected "str | int") [misc] | |||
| posthog/models/property/util.py:0: error: Argument 3 to "format_filter_query" has incompatible type "HogQLContext | None"; expected "HogQLContext" [arg-type] | |||
| posthog/models/property/util.py:0: error: Argument 3 to "format_cohort_subquery" has incompatible type "HogQLContext | None"; expected "HogQLContext" [arg-type] | |||
| posthog/models/property/util.py:0: error: Invalid index type "tuple[str, str]" for "dict[tuple[str, Literal['properties', 'group_properties', 'person_properties']], str]"; expected type "tuple[str, Literal['properties', 'group_properties', 'person_properties']]" [index] | |||
There was a problem hiding this comment.
These aren't particularly problematic and trying to fix them just moves the errors up the stack to all the call sites instead and don't want to deal with them right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cache_foris a type checking black hole.This makes it easy to introduce errors when refactoring things like
get_materialized_columnswhich use the decorator.Changes
cache_forso that parameters and return types can be type checked.CachedFunctionclass because mypy doesn't like it when you stuff additional attributes onto function types.Does this work well for both Cloud and self-hosted?
Yes.
How did you test this code?
mypy