Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Support type checking from cache_for decorator #26052

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

refactor: Support type checking from cache_for decorator #26052

wants to merge 9 commits into from
+56 −39

Commits on Nov 7, 2024

  1. kinda sorta

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    77fa7ee View commit details
    Browse the repository at this point in the history

  2. support return type from cached function, at least

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    330d1aa View commit details
    Browse the repository at this point in the history

  3. make the key type a bit more specific

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fa54a57 View commit details
    Browse the repository at this point in the history

  4. pedantic sorting

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7d4778c View commit details
    Browse the repository at this point in the history

  5. fix one of the typing issues

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a8607b7 View commit details
    Browse the repository at this point in the history

  6. add the other ones to baseline because either they're already caught … 

    …(for better or for worse) or fixing them causes more problems than it solves
    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    bd01311 View commit details
    Browse the repository at this point in the history

  7. use dataclass so we can use slots

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1af66ee View commit details
    Browse the repository at this point in the history

  8. validate parameters also

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5a66d54 View commit details
    Browse the repository at this point in the history

  9. clean up repr

    @tkaemming
    tkaemming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    73fd962 View commit details
    Browse the repository at this point in the history