fix(flags): parse application/json content-type headers in a less brittle way (while still respecting compression headers)
#31798
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified content-type header parsing in feature flags API to handle requests with charset specifications, fixing iOS client compatibility issues.
- Updated
rust/feature-flags/src/api/request_handler.rsto usestarts_withfor content-type validation instead of exact matching - Added test case to verify handling of
application/json; charset=utf-8content-type headers - Maintains existing compression header support while being more lenient with charset specifications
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Pull Request Overview
This PR relaxes the parsing of content-type headers to handle JSON requests more flexibly and to support different encoding and compression scenarios.
- Adjusts base64 handling based solely on an explicit content-type header
- Refines the matching of "application/json" with potential additional parameters
- Adds a test to validate decoding of requests with a charset in the content-type header
Co-authored-by: Copilot <[email protected]>
| // Special case: if the Content-Type header explicitly specifies base64 encoding, | ||
| // this takes precedence over the query parameter for compression. In this case, | ||
| // the body is decoded as base64, and the query parameter is disregarded. | ||
| if content_type.starts_with("application/json; encoding=base64") { |
There was a problem hiding this comment.
Shouldn't we parse the content type and then compare. For example, this is a valid content type: Content-Type: application/json; charset=utf-8; encoding=base64
There was a problem hiding this comment.
per slack: I'm just going to explicitly support the content types that we send from our SDKs.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
Fixes the issue @ioannisj noticed here: PostHog/posthog-ios#345 (comment)
Was being too picky in parsing content-type headers.
Changes
Does this work well for both Cloud and self-hosted?
Yes