Increasing timeouts for generation to 15 seconds #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajbozarth
requested changes
Jun 5, 2025
Comment on lines
+44
to
+59
| }, | ||
| "providerTimeout": { | ||
| "title": "Provider Timeout (milliseconds)", | ||
| "description": "Timeout for completion provider requests in milliseconds. Recommended value is 15000 (15 seconds) for Qiskit Code Assistant API.", | ||
| "type": "number", | ||
| "default": 15000, | ||
| "minimum": 1000, | ||
| "maximum": 30000 | ||
| }, | ||
| "inlineProviderTimeout": { | ||
| "title": "Inline Provider Timeout (milliseconds)", | ||
| "description": "Timeout for inline completion provider requests in milliseconds.", | ||
| "type": "number", | ||
| "default": 15000, | ||
| "minimum": 1000, | ||
| "maximum": 30000 |
There was a problem hiding this comment.
These settings already exist in core jupyterlab. I'm unsure of the ramifications of duplicating them here
| schema: ISettingRegistry.IProperty = { | ||
| default: { | ||
| enabled: true, | ||
| timeout: 10000 |
There was a problem hiding this comment.
from what I can tell we can achieve the same results by just increasing this value instead of the surrounding code changes
Comment on lines
+85
to
+88
| get timeout(): number { | ||
| return (this.settings.composite['providerTimeout'] as number) || 15000; | ||
| } | ||
|
|
There was a problem hiding this comment.
(without checking the core code) is this overriding something? where is this called
This was referenced Jun 26, 2025
|
Thanks for the review, Alex. I think this is not the proper way to do it, so I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increasing the
providerTimeoutandinlineProviderTimeoutto 15 seconds by defaultLinked Issue(s)
Fixes #22
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Manually
Checklist: