Fix wrong logo position on plymouth #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add "window" position to the logo/progress position. On a single
screen system, that position is always (0,0), but on multi-screen system
it's a position of the output. It seems that plymouth calls relevant
callbacks for each output ("window") separately, so there is no need to
add window position manually.
Fixes https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/205
This was referenced Sep 13, 2024
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091400-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests69 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 7 fixed
Unstable tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add "window" position to the logo/progress position. On a single
screen system, that position is always (0,0), but on multi-screen system
it's a position of the output. It seems that plymouth calls relevant
callbacks for each output ("window") separately, so there is no need to
add window position manually.
Fixes https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/205