Devices widget: label recently-connected devices as "NEW" #207
Conversation
|
@marmarek I've now pushed the PR with my signing key. |
|
PipelineRetry |
|
pylint: |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024071717-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests40 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 8 fixed
Unstable tests
|
|
|
@marmarek corrected the pylint and initial value error |
|
pylint complains about trailing whitespace... |
Fixes Pylint trailing whitespace
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 93.54% 93.55%
=======================================
Files 57 57
Lines 10816 10823 +7
=======================================
+ Hits 10118 10125 +7
Misses 698 698 ☔ View full report in Codecov by Sentry. |
|
@marmarek all set. thank you for your patience! |
|
sorry for being a complainer, but: I'm not that sure about two things. One is red color of the font - red is generally a "bad" color, although recently it has also been used for "new stuff". Two is the exclamation mark, which makes it even scarier for a user (at least I get this feeling). Maybe it would be a bit less scary if the NEW was blue, in one of the Qubes Blue colors (e.g. primary blue: https://www.qubes-os.org/doc/visual-style-guide/ ) |
@marmarta Would adding "qubes-blue" work within the span style, or would I also need to load_css from qubes-colors-dark.css? Using "blue" would also work, but it would be outside the style framework. |
Removes exclamation mark and changes text color from red to blue
Sadly, Gtk is not great here and you can't use CSS stuff in span (worse, they literally rejected a PR that would add it, because "they want to go in the direction of more widgets") - you can just use the literal color number ( #3874d8 or #63a0ff , not sure which would look better, probably the lighter one |
Following Qubes Visual Style Guide https://www.qubes-os.org/doc/visual-style-guide/
|
looks really good! |
fixes: QubesOS/qubes-issues#8543