-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removing VM from obsolete_vms #210
Conversation
The domain-delete event gets string as a 'vm' argument, so use it directly instead of accessing its 'name' attribute. Fixes: 25f1be1 "Remove VM from obsolete_vms list if template is deleted"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 57 57
Lines 10823 10823
=======================================
Hits 10126 10126
Misses 697 697 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024071717-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests40 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 8 fixed
Unstable tests
|
The domain-delete event gets string as a 'vm' argument, so use it
directly instead of accessing its 'name' attribute.
Fixes: 25f1be1 "Remove VM from obsolete_vms list if template is deleted"