This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
initial PR to toggle quic support and add esp threading #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimEvens
reviewed
Sep 1, 2023
CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| option(QUIC_TRANSPORT "Enable QUIC Transport (Default ON)" ON) |
There was a problem hiding this comment.
Considering selection of UDP vs QUIC vs H3 vs maybe TCP in the future is at execution time, disabling QUIC or any other transport protocol option would invalidate the execution time config and use-cases to support that.
What was the reason to not compile in the other protocols? Is it that the dependencies with QUIC are too much causing pain for testing? If so, maybe we wrap this into TEST knobs.
There was a problem hiding this comment.
this is a temporary fix to get esp builds going. PicoTLS has been updated to support mbed tls then we don't need this anymore.
TimEvens
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in minimal support to
The latter of the 2 will be revisited once we have basic integration working