Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CAN bus and ODrive Motor components #45

Open
wants to merge 15 commits into
base: feat/can-motor-controller
Choose a base branch
from
Open

Add CAN bus and ODrive Motor components #45

wants to merge 15 commits into from
+517 −52

Conversation

Slaith12
Copy link
Collaborator

@Slaith12 Slaith12 commented Oct 26, 2024 •
edited
Loading

Feature

  • Adds can_bus and odrive_motor components
  • can_bus handles all CAN messaging and bus configuration, and is able to pass on received messages to other components that call add_listener()
  • odrive_motor controls the ODrive motor controller and can be used to read its current state and control its position/velocity

How to Test

  • Run odrive_motor_test.py

hiromon0125
hiromon0125 reviewed Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@hiromon0125 hiromon0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets just get this fully tested today and make sure this all works

src/raspi/component/can/can_bus.py Show resolved Hide resolved
src/raspi/component/motor/odrive_motor.py Outdated Show resolved Hide resolved
@hiromon0125 hiromon0125 marked this pull request as ready for review November 3, 2024 20:27
hiromon0125
hiromon0125 requested changes Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@hiromon0125 hiromon0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

src/raspi/component/can/can_bus.py Outdated Show resolved Hide resolved
src/raspi/component/can/can_bus.py Outdated Show resolved Hide resolved
src/raspi/component/can/can_bus.py Show resolved Hide resolved
src/raspi/component/can/can_bus.py Show resolved Hide resolved
src/raspi/component/motor/odrive_motor.py Outdated Show resolved Hide resolved
src/raspi/component/motor/odrive_motor.py Outdated Show resolved Hide resolved
src/raspi/component/motor/odrive_motor.py Outdated Show resolved Hide resolved
src/raspi/component/motor/odrive_motor.py Outdated Show resolved Hide resolved
src/raspi/component/motor/odrive_motor.py Outdated Show resolved Hide resolved
@hiromon0125 hiromon0125 added the enhancement New feature or request label Nov 3, 2024
@hiromon0125
Copy link
Collaborator

Add a little bit more detailed description of the features added in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiromon0125 hiromon0125 hiromon0125 requested changes

@cvr8924 cvr8924 Awaiting requested review from cvr8924 cvr8924 is a code owner

Assignees

@Slaith12 Slaith12

Labels
enhancement New feature or request
Projects
Software Project Board V0.2
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Slaith12 @hiromon0125 @mdrc-catbot