Prevent sampling when thread is shutting down #224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The parameter "year" was removed from amdsmi_version_t. - For SWDEV-535858, SWDEV-535870
* SWDEV-533856: Handle dynamic event for HIP api for perfetto * Refactor: Generalize function using template * Format Source --------- Co-authored-by: David Galiffi <[email protected]>
--------- Co-authored-by: David Galiffi <[email protected]>
- Move the MPI gotcha functionality from Timemory to the repo. - Add the PMPI Fortran MPI functions to the existing mpi gotcha handle.
Fixed the kernel names used for validation --------- Signed-off-by: David Galiffi <[email protected]>
#230) * SWDEV-507117: Unify OMP Target Offload Events into a Single Perfetto Timeline Row * Fixed warning and format --------- Co-authored-by: David Galiffi <[email protected]>
- Add support for RCCL API tracing through rocprofiler-sdk. - Refactored the comm_data code to use the SDK RCCL_API callbacks. - Add a runtime version check for SDK to gate callback enablement, rather than just the compile-time check. - Fixed: SAMPLING_TIMEOUT was not being handled correctly in add_test.
Update Dyninst submodule Refactoring of build scripts to build TBB, Boost, ElfUtils, and LibIberty, since Dyninst build scripts no longer do. Workflows are now building Dyninst and its dependencies. --------- Co-authored-by: marantic-amd <[email protected]> Co-authored-by: David Galiffi <[email protected]>
… devices (#226) * SWDEV-535445: rocprof-sys-avail shows jpeg_activity even when unsupported * Added vcn tracking * jpeg and vcn description now includes supported gpus * Add getter methods per device to check vcn and jpeg support Add logic to check if vcn activity and vcn busy values are supported for each device. Add logic to check if jpeg activity and jpeg busy values are supported for each device. Co-authored-by: Sajina P Kandy <[email protected]> * Add getter methods per device to check vcn and jpeg support (#228) * Formatting * Variable fix * List of supported GPUs are now ordered * Removed the ability to see which gpu supports jpeg and vcn activity to reduce clutter * Formatting * Testing for busy support * jpeg and vcn only show if supported * Removed commented code * Formatting * Applied amd_smi cpp/hpp fixes * Added break condition for xcp loop * Modified loops for efficiency * Removed unneccessary macro * Removed unneccessary includes --------- Co-authored-by: Sajina Kandy <[email protected]> Co-authored-by: Sajina PK <[email protected]>
…inx (#239) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.20.0 to 1.20.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.20.1/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.20.0...v1.20.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.20.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Test is missing from rocm-7.0 stack because of a HIP version check. In these builds, hip_version.h is still reporting 6.5.0. This check was originally put in to skip the test on older versions of ROCm, which should no longer be required - For SWDEV-537718 Signed-off-by: David Galiffi <[email protected]>
Update Timemory / GOTCHA modules Signed-off-by: David Galiffi <[email protected]>
Using miniforge instead of miniconda Signed-off-by: David Galiffi <[email protected]>
…m/ROCm/rocprofiler-systems into darren-amd/fix-shutdown-execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for SWDEV-533419 aims to prevent sampling when the timemory thread is being shutdown by rocprof-sys.
Pending on: ROCm/timemory#6 before merging