Skip to content

Prevent sampling when thread is shutting down #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Prevent sampling when thread is shutting down #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f54be75
Signal to timemory when shutting down sampler
darren-amd May 29, 2025
650827c
Fix compilation failure in amd-smi 26.0.0 (#223)
dgaliffiAMD Jun 2, 2025
abecaa8
SWDEV-533856: Handle dynamic event for HIP api for perfetto (#225)
habajpai-amd Jun 4, 2025
b98c3c8
Fixed NIC performance monitoring test (#189)
ajanicijamd Jun 4, 2025
4fcd8cc
Enable MPI tracing for Fortran (#185)
sputhala-amd Jun 4, 2025
867020c
Fix validate-openmp-target-sampling-perfetto test (#231)
dgaliffiAMD Jun 6, 2025
c5507e3
SWDEV-507117: Unify OMP Target Offload Events into a Single Perfetto …
habajpai-amd Jun 6, 2025
af77d93
Use rocprofiler-sdk for RCCL-API tracing (#126)
dgaliffiAMD Jun 6, 2025
96df9b6
Update dyninst to v13 (#190)
pranswarup Jun 7, 2025
92b636a
Update opensuse.yml (#236)
dgaliffiAMD Jun 9, 2025
0380cf5
Improve rocprof-sys-avail to report VCN and JPEG metrics on supported…
kcossett-amd Jun 9, 2025
0d3d051
Bump rocm-docs-core[api_reference] from 1.20.0 to 1.20.1 in /docs/sph…
dependabot[bot] Jun 10, 2025
28bee27
Fix OpenMP-Target ctest (#241)
dgaliffiAMD Jun 11, 2025
c00070d
Change docker scripts to use miniforge instead of miniconda (#242)
pranswarup Jun 12, 2025
d9381c3
SWDEV-525474 - Fixed CMake 4 configuration error (#244)
dgaliffiAMD Jun 12, 2025
877fa67
Updated Dockerfile.ubuntu (#245)
dgaliffiAMD Jun 12, 2025
e0de63f
Signal to timemory when shutting down sampler
darren-amd May 29, 2025
82d4cab
Merge branch 'darren-amd/fix-shutdown-execution' of https://github.co…
darren-amd Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/opensuse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ jobs:
-DROCPROFSYS_USE_ROCM=OFF
-DROCPROFSYS_USE_OMPT=OFF
-DROCPROFSYS_USE_PYTHON=ON
-DROCPROFSYS_BUILD_DYNINST=ON
-DROCPROFSYS_BUILD_BOOST=ON
-DROCPROFSYS_BUILD_TBB=ON
-DROCPROFSYS_BUILD_ELFUTILS=ON
-DROCPROFSYS_BUILD_LIBIBERTY=ON
-DROCPROFSYS_INSTALL_PERFETTO_TOOLS=OFF
-DROCPROFSYS_USE_MPI_HEADERS=ON
-DROCPROFSYS_PYTHON_PREFIX=/opt/conda/envs
Expand All @@ -107,7 +112,7 @@ jobs:
-DROCPROFSYS_DISABLE_EXAMPLES="transpose;rccl;openmp-target;videodecode;jpegdecode"
-DROCPROFSYS_BUILD_NUMBER=${{ github.run_attempt }}
--
-LE "transpose|rccl|videodecode|jpegdecode|network"
-LE "transpose|rccl|videodecode|jpegdecode|network|mpi"

- name: Install
timeout-minutes: 10
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/redhat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ jobs:
-DROCPROFSYS_USE_ROCM=${USE_HIP}
-DROCPROFSYS_USE_OMPT=OFF
-DROCPROFSYS_USE_PYTHON=ON
-DROCPROFSYS_BUILD_DYNINST=ON
-DROCPROFSYS_BUILD_BOOST=ON
-DROCPROFSYS_BUILD_TBB=ON
-DROCPROFSYS_BUILD_ELFUTILS=ON
-DROCPROFSYS_BUILD_LIBIBERTY=ON
-DROCPROFSYS_USE_MPI_HEADERS=ON
-DROCPROFSYS_CI_MPI_RUN_AS_ROOT=ON
-DROCPROFSYS_MAX_THREADS=64
Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/ubuntu-focal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ jobs:
-DROCPROFSYS_USE_ROCM=OFF
-DROCPROFSYS_USE_OMPT=OFF
-DROCPROFSYS_USE_PAPI=OFF
-DROCPROFSYS_BUILD_DYNINST=ON
-DROCPROFSYS_BUILD_BOOST=ON
-DROCPROFSYS_BUILD_TBB=ON
-DROCPROFSYS_BUILD_ELFUTILS=ON
-DROCPROFSYS_BUILD_LIBIBERTY=ON
-DROCPROFSYS_USE_PYTHON=${{ matrix.python }}
-DROCPROFSYS_USE_MPI_HEADERS=${{ matrix.mpi-headers }}
-DROCPROFSYS_STRIP_LIBRARIES=${{ matrix.strip }}
Expand Down Expand Up @@ -346,6 +351,11 @@ jobs:
-DROCPROFSYS_USE_OMPT=OFF
-DROCPROFSYS_USE_PYTHON=ON
-DROCPROFSYS_USE_MPI_HEADERS=${{ matrix.mpi-headers }}
-DROCPROFSYS_BUILD_DYNINST=ON
-DROCPROFSYS_BUILD_BOOST=ON
-DROCPROFSYS_BUILD_TBB=ON
-DROCPROFSYS_BUILD_ELFUTILS=ON
-DROCPROFSYS_BUILD_LIBIBERTY=ON
-DROCPROFSYS_USE_SANITIZER=OFF
-DROCPROFSYS_PYTHON_PREFIX=/opt/conda/envs
-DROCPROFSYS_PYTHON_ENVS="py3.6;py3.7;py3.8;py3.9;py3.10;py3.11"
Expand Down Expand Up @@ -455,7 +465,11 @@ jobs:
-DCMAKE_INSTALL_PREFIX=/opt/rocprofiler-systems
-DROCPROFSYS_BUILD_CI=OFF
-DROCPROFSYS_BUILD_TESTING=ON
-DROCPROFSYS_BUILD_DYNINST=OFF
-DROCPROFSYS_BUILD_DYNINST=ON
-DROCPROFSYS_BUILD_BOOST=ON
-DROCPROFSYS_BUILD_TBB=ON
-DROCPROFSYS_BUILD_ELFUTILS=ON
-DROCPROFSYS_BUILD_LIBIBERTY=ON
-DROCPROFSYS_BUILD_DEBUG=OFF
-DROCPROFSYS_BUILD_HIDDEN_VISIBILITY=OFF
-DROCPROFSYS_USE_MPI=ON
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/ubuntu-jammy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
hidden: ['ON', 'OFF']
build-type: ['Release']
mpi-headers: ['ON', 'OFF']
build-dyninst: ['OFF']
build-dyninst: ['ON']
rocm-version: ['0.0']

env:
Expand Down Expand Up @@ -133,6 +133,10 @@ jobs:
-DROCPROFSYS_USE_PYTHON=${{ matrix.python }}
-DROCPROFSYS_USE_MPI_HEADERS=${{ matrix.mpi-headers }}
-DROCPROFSYS_BUILD_DYNINST=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_BOOST=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_TBB=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_ELFUTILS=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_LIBIBERTY=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_HIDDEN_VISIBILITY=${{ matrix.hidden }}
-DROCPROFSYS_PYTHON_PREFIX=/opt/conda/envs
-DROCPROFSYS_PYTHON_ENVS="py3.7;py3.8;py3.9;py3.10;py3.11"
Expand Down Expand Up @@ -210,7 +214,7 @@ jobs:
hidden: ['ON']
build-type: ['Release']
mpi-headers: ['OFF']
build-dyninst: ['OFF']
build-dyninst: ['ON']
rocm-version: ['6.3', '6.4']

env:
Expand Down Expand Up @@ -310,6 +314,10 @@ jobs:
-DROCPROFSYS_USE_PYTHON=${{ matrix.python }}
-DROCPROFSYS_USE_MPI_HEADERS=${{ matrix.mpi-headers }}
-DROCPROFSYS_BUILD_DYNINST=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_BOOST=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_TBB=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_ELFUTILS=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_LIBIBERTY=${{ matrix.build-dyninst }}
-DROCPROFSYS_BUILD_HIDDEN_VISIBILITY=${{ matrix.hidden }}
-DROCPROFSYS_PYTHON_PREFIX=/opt/conda/envs
-DROCPROFSYS_PYTHON_ENVS="py3.7;py3.8;py3.9;py3.10;py3.11"
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ubuntu-noble.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ jobs:
-DROCPROFSYS_DISABLE_EXAMPLES="transpose;rccl;openmp-target" \
-DROCPROFSYS_USE_ROCM=${USE_ROCM} \
-DRCOPROFSYS_USE_PYTHON=ON \
-DROCPROFSYS_BUILD_DYNINST=ON \
-DROCPROFSYS_BUILD_BOOST=ON \
-DROCPROFSYS_BUILD_TBB=ON \
-DROCPROFSYS_BUILD_ELFUTILS=ON \
-DROCPROFSYS_BUILD_LIBIBERTY=ON \
-DROCPROFSYS_STRIP_LIBRARIES=${{ matrix.strip }} \
-DROCPROFSYS_PYTHON_PREFIX=/opt/conda/envs \
-DROCPROFSYS_PYTHON_ENVS="py3.8;py3.9;py3.10;py3.11;py3.12"
Expand Down
1 change: 1 addition & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
[submodule "external/dyninst"]
path = external/dyninst
url = https://github.com/ROCm/dyninst.git
branch = dyninst_13
[submodule "external/PTL"]
path = external/PTL
url = https://github.com/jrmadsen/PTL.git
Expand Down
12 changes: 5 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR AND CMAKE_CURRENT_SOURCE_DIR STREQ
message(AUTHOR_WARNING "In-source build")
endif()

# find_package() uses upper-case <PACKAGENAME>_ROOT variables.
if(POLICY CMP0144)
cmake_policy(SET CMP0144 NEW)
endif()

if(NOT UNIX OR APPLE)
message(
AUTHOR_WARNING
Expand Down Expand Up @@ -179,7 +184,6 @@ rocprofiler_systems_add_option(ROCPROFSYS_USE_MPI "Enable MPI support" OFF)
rocprofiler_systems_add_option(ROCPROFSYS_USE_ROCM "Enable ROCm support" ON)
rocprofiler_systems_add_option(ROCPROFSYS_USE_PAPI "Enable HW counter support via PAPI"
ON)
rocprofiler_systems_add_option(ROCPROFSYS_USE_RCCL "Enable RCCL support" OFF)
rocprofiler_systems_add_option(
ROCPROFSYS_USE_MPI_HEADERS
"Enable wrapping MPI functions w/o enabling MPI dependency" ON)
Expand Down Expand Up @@ -209,12 +213,6 @@ elseif("$ENV{ROCPROFSYS_CI}")
endif()
endif()

if(NOT ROCPROFSYS_USE_ROCM)
set(ROCPROFSYS_USE_RCCL
OFF
CACHE BOOL "Disabled via ROCPROFSYS_USE_ROCM=OFF" FORCE)
endif()

if(ROCPROFSYS_BUILD_TESTING)
set(ROCPROFSYS_BUILD_EXAMPLES
ON
Expand Down
6 changes: 3 additions & 3 deletions cmake/ConfigCPack.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,16 @@ if(ROCPROFSYS_USE_PAPI AND NOT ROCPROFSYS_BUILD_PAPI)
list(APPEND _DEBIAN_PACKAGE_DEPENDS libpapi-dev libpfm4)
endif()
if(NOT ROCPROFSYS_BUILD_DYNINST)
if(NOT DYNINST_BUILD_BOOST)
if(NOT ROCPROFSYS_BUILD_BOOST)
foreach(_BOOST_COMPONENT atomic system thread date-time filesystem timer)
list(APPEND _DEBIAN_PACKAGE_DEPENDS
"libboost-${_BOOST_COMPONENT}-dev (>= 1.67.0)")
endforeach()
endif()
if(NOT DYNINST_BUILD_TBB)
if(NOT ROCPROFSYS_BUILD_TBB)
list(APPEND _DEBIAN_PACKAGE_DEPENDS "libtbb-dev (>= 2018.6)")
endif()
if(NOT DYNINST_BUILD_LIBIBERTY)
if(NOT ROCPROFSYS_BUILD_LIBIBERTY)
list(APPEND _DEBIAN_PACKAGE_DEPENDS "libiberty-dev (>= 20170913)")
endif()
endif()
Expand Down
Loading
Loading