Phosphor Icons #40
Merged
Phosphor Icons #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge this and tackle the filename transforming/normalization in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like a great collection of icons.
Find a way to “normalize” the icon names (they are stored with the variant name appended to them, eg.acorn-bold.svgmeaning an icon would be referenced asacorn-boldinstead of justacorn)The "normalization" task needs some consideration. Is it something that should be added at all? If so, how generic should it be (eg. I've seen a library put each icon in a separate named folder another library prefixed each name, like
bx-).