Skip to content

tests, net, service-mesh: Drop usage of 'running_vm' #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/network/service_mesh/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
)
from utilities.constants import PORT_80, TIMEOUT_4MIN, TIMEOUT_10SEC
from utilities.infra import add_scc_to_service_account, create_ns, label_project, unique_name
from utilities.virt import running_vm, vm_console_run_commands, wait_for_console
from utilities.virt import vm_console_run_commands, wait_for_console

LOGGER = logging.getLogger(__name__)

Expand Down Expand Up @@ -235,7 +235,8 @@ def vm_fedora_with_service_mesh_annotation(
service_name=vm_name,
port=SERVICE_MESH_PORT,
)
running_vm(vm=vm, wait_for_interfaces=False, check_ssh_connectivity=False)
vm.start(wait=True)
vm.wait_for_agent_connected()
yield vm


Expand All @@ -254,7 +255,8 @@ def outside_mesh_vm_fedora_with_service_mesh_annotation(
service_name=vm_name,
port=SERVICE_MESH_PORT,
)
running_vm(vm=vm, wait_for_interfaces=False, check_ssh_connectivity=False)
vm.start(wait=True)
vm.wait_for_agent_connected()
yield vm


Expand Down