fix: use valid multi-exception syntax

[geetikakay]

Short description:

using ValueError | AttributeError | TypeError: multi exception ends with TypeError: catching classes that do not inherit from BaseException is not allowed.

More details:

For 3.14 python here are some tested formats

Python 3.14.0 (main, Oct 28 2025, 12:13:17) [Clang 20.1.4 ] on linux
Type "help", "copyright", "credits" or "license" for more information.

try:
... raise ValueError("x")
... except (ValueError, AttributeError, TypeError):
... print("caught")
...
caught
try:
... raise ValueError("x")
... except ValueError, AttributeError, TypeError:
... print("caught")
...
caught
try:
... raise ValueError("x")
... except ValueError | AttributeError | TypeError: # type: ignore[misc]
... print("caught")
...
Traceback (most recent call last):
File "", line 2, in
raise ValueError("x")
ValueError: x

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "", line 3, in
except ValueError | AttributeError | TypeError: # type: ignore[misc]
print("caught")
TypeError: catching classes that do not inherit from BaseException is not allowed

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Tests

  • Standardized exception handling across test utilities for consistent, compatible error handling; no behavioral changes.

• Chores

  • Updated pre-commit configuration to use python3.14 as the default interpreter.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-virtualization-qe-bot-3]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open (optional)
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• geetikakay
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[coderabbitai]

📝 Walkthrough

Walkthrough

Replaced several invalid/older multi-exception except syntaxes with tuple-style exception catches across tests and utilities; updated pre-commit config default interpreter from python3 to python3.14. No functional logic, signatures, or control-flow changes detected. (≈34 words)

Changes

Cohort / File(s)	Summary
Exception handling syntax updates tests/infrastructure/golden_images/update_boot_source/utils.py, tests/storage/utils.py, tests/virt/cluster/longevity_tests/utils.py, tests/virt/utils.py, utilities/hco.py, utilities/infra.py	Replaced invalid/unsupported multi-exception forms with tuple-style catches, e.g. changed `except ValueError
Pre-commit Python interpreter update .pre-commit-config.yaml	Updated default_language_version and hook language_version from python3 to python3.14.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• dshchedr
• vsibirsk
• RoniKishner

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description provides a short description explaining the core issue with Python 3.14 and includes concrete test output demonstrating why the union syntax fails. However, several required template sections are missing or incomplete: 'More details' is populated with test output but lacks explanation, 'What this PR does / why we need it' is empty, 'Which issue(s) this PR fixes' is empty, 'Special notes for reviewer' is empty, and 'jira-ticket' is not provided.	Complete the description template by filling in 'What this PR does / why we need it', 'Which issue(s) this PR fixes', and 'Special notes for reviewer' sections; provide jira-ticket URL or write NONE.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: use valid multi-exception syntax' directly and accurately describes the main change across all files: replacing invalid union-style exception syntax with valid tuple-based or parenthesized syntax.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@tests/infrastructure/golden_images/update_boot_source/utils.py`:
- Line 162: Replace the invalid Python2-style except clause `except ValueError,
AttributeError, TypeError:` with the Python3 tuple form `except (ValueError,
AttributeError, TypeError):` in the try/except block in utils.py (the block
handling the conversion/validation logic around that line); do not bind the
exception to a variable there, and use the tuple form as required for mypy
compatibility.

[geetikakay]

/build-and-push-container

[openshift-virtualization-qe-bot-3]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3559 published

[coderabbitai]

Actionable comments posted: 5

🤖 Fix all issues with AI agents

In `@tests/virt/cluster/longevity_tests/utils.py`:
- Around line 228-232: The except clause currently uses Python2 comma syntax
which is invalid; update the except in the try/except around
wait_for_ssh_connectivity and os_dict["fetch_pid"] to use a tuple of exceptions
(e.g., replace the comma-separated list with a parenthesized tuple containing
AssertionError, ValueError and TimeoutExpiredError) so the block catching those
exceptions and appending to rebooted_vms works in Python 3 and passes mypy.
- Around line 172-175: Replace the invalid Python 2 exception syntax used when
catching multiple exceptions in the block that calls os_dict["fetch_pid"] (where
new_pid is assigned and vms_with_wrong_pids_dict updated) and the second
identical occurrence later: change the comma-separated form `except
AssertionError, ValueError:` to the Python 3 tuple form `except (AssertionError,
ValueError):` so the except clauses parse correctly in Python 3.

In `@tests/virt/utils.py`:
- Around line 147-150: The except clause using comma syntax is invalid in Python
3; update the exception handling around the verify_vm_migrated call so it
catches both exceptions using a tuple: replace the line "except AssertionError,
TimeoutExpiredError:" with "except (AssertionError, TimeoutExpiredError):" so
failed_migrations_list.append(vm.name) runs when verify_vm_migrated(vm=vm,
node_before=vm_sources['node_before']) raises either exception.

In `@utilities/hco.py`:
- Around line 559-562: Replace the invalid Python2-style exception clause in the
AAQ PODs cleanup block: change the clause that currently reads "except
NotFoundError, ResourceNotFoundError:" to use a parenthesized tuple of
exceptions (i.e., except (NotFoundError, ResourceNotFoundError):) so the module
parses under Python 3; ensure the LOGGER.info("AAQ system PODs removed.")
remains inside that except block and no other logic is altered.

In `@utilities/infra.py`:
- Around line 251-254: Replace the invalid Python 2-style exception syntax in
the except clause: change the line using "except ResourceNotFoundError,
NotFoundError:" to use tuple form "except (ResourceNotFoundError,
NotFoundError):" so the handler around
get_pod_container_error_status/pods_not_running/LOGGER is valid under Python
3.14 and mypy-friendly; ensure you update the except clause in the same block
where pod handling and LOGGER.warning are used.

♻️ Duplicate comments (1)

tests/infrastructure/golden_images/update_boot_source/utils.py (1)

159-163: HIGH: PEP 758 comma syntax may still break tooling (mypy/flake8).
Unparenthesized comma exceptions are new in 3.14; older parsers (notably mypy/flake8 configurations) can still raise E999 or parse errors. The parenthesized tuple is compatible across toolchains and avoids pre-commit/CI failures.

🔧 Suggested compatibility fix

-    except ValueError, AttributeError, TypeError:
+    except (ValueError, AttributeError, TypeError):

Does mypy 1.19.x support PEP 758 “except A, B:” comma syntax in Python 3.14?

Based on learnings, prefer tuple-form multi-exception catches for mypy compatibility.