Skip to content

Adds Clique Seeding Example #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

wernerpe
Copy link

@wernerpe wernerpe commented Jul 18, 2024

I am not sure how to properly add the image to the manipulation-data repo. I opened a separate PR here: RussTedrake/manipulation-data#4


This change is Reviewable

@wernerpe
Copy link
Author

wernerpe commented Jul 26, 2024

Oops, I just saw I was using networkx to plot the connectivity graphs - which is causing CI to fail. I will fix that.

@RussTedrake RussTedrake self-assigned this Sep 23, 2024
@wernerpe wernerpe force-pushed the clique_seeding_manual_distribution branch from e0a474a to 16dff98 Compare September 25, 2024 18:45
wernerpe and others added 16 commits September 25, 2024 15:07
* Update analytic_grasp test cases

* Modify the placement of points for SDF problem

* shrink sdf img

* lint and removing formatting comments

* Update test_analytic_grasp.py

* Sync changes

---------

Co-authored-by: Nicholas Pfaff <[email protected]>
* increase 5.4b time limit

* increase time limit
* modifying grader for new target values

* updating notebook

* typo fix
* additional avenue of obj files

* Simulation Setup Problem Notebook

* updated simulation setup notebook

* changing wording of 7.1

* updating parser behaviour 7.1

* quick path removal

* table top inertia, plant config
shrutigarg914 and others added 4 commits October 11, 2024 06:19
* moving notebook to 7 instead of 5

* updating exercise notebook link
homebrew introduced [email protected] and broke our current uses of 3.12.
and a few other minor edits/cleanups.
Copy link
Owner

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again Pete. I've just pushed some minor fixes to your branch to make it pass CI (using the running_as_notebook variable to guard against things that would be too slow, or actually even loop forever). PTAL.

It still makes the test really slow for CI, so if there is more you can do in this direction, please consider it.

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 33 files reviewed, 3 unresolved discussions (waiting on @wernerpe)


book/trajectories/iris_builder.ipynb line 1041 at r2 (raw file):

    "\n",
    "\n",
    "def resize_svg(svg_b, width_user: int):\n",

wow. that's complicated! can't you just call e.g.

# Set the desired width (in inches)
graph.set_size("8,4!")

on the pydot object before calling create_svg?


book/trajectories/iris_builder.ipynb line 1065 at r2 (raw file):

    "\n",
    "# plotting function for later\n",
    "def plot_region_connectivity(\n",

can we replace/merge this with the VisualizeConnectivity() method that already exists below?


book/data line 1 at r1 (raw file):

Subproject commit 05a36fd9d620241fb93facd4f45e01a7612a7fa7

i've merged the other branch, so let's just make sure we update to that commit.

@RussTedrake RussTedrake assigned wernerpe and unassigned RussTedrake Nov 11, 2024
@RussTedrake
Copy link
Owner

This example is making too many regions for GcsTrajOpt to handle elegantly. Let's wait until the GCS* code lands... and see if it helps.

@RussTedrake RussTedrake marked this pull request as draft November 14, 2024 10:27
@RussTedrake RussTedrake self-requested a review November 14, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants