feat: 🎸 [HCPSDKFIORIUIKIT-3063]Semantic Message Alignment #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhuachu
reviewed
Oct 24, 2025
|
|
||
| // sourcery: CompositeComponent, InternalComponent | ||
| // sourcery: CompositeComponent | ||
| protocol _TextInputInfoViewComponent: _InformationViewComponent, _CounterComponent {} |
There was a problem hiding this comment.
This _TextInputInfoViewComponent changed to public without header docs. Please add header docs so that the generated structs will have docs.
janhuachu
requested changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate semantic message issues (particuarly with Text Input components: text field form cell, key value form cell, note form cell, title form cell) to align with Android:
1.character count
.Padding on right side
.error state color change
2.typing state Label color
3.Icon inside text box: alignment with text & behavior with expanding text box
4.error message prioritization over other semantic messages