-
Notifications
You must be signed in to change notification settings - Fork 61
feat: 🎸 [HCPSDKFIORIUIKIT-3063]Semantic Message Alignment #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KevinZK
wants to merge
1
commit into
SAP:main
Choose a base branch
from
KevinZK:JIRA-3063_formViewSemanticMessage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
Apps/Examples/Examples/FioriSwiftUICore/FormViews/SemanticMessageExample.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| import FioriSwiftUICore | ||
| import FioriThemeManager | ||
| import SwiftUI | ||
|
|
||
| struct SemanticMessageExample: View { | ||
| let errorMessage = AttributedString("Error Message") | ||
| let hintText = AttributedString("Hint Text") | ||
| @State var showsHintText = false | ||
| @State var showsErrorMessage = false | ||
| @State var showsCharCount = false | ||
| @State var allowsBeyondLimit = false | ||
| @State var showAINotice: Bool = false | ||
| @State var isLoading: Bool = false | ||
| @State var valueText: String = "" | ||
| @State var longHelperText: Bool = false | ||
| @State var longAINoticeText: Bool = false | ||
| @State var semanticIndex: Int = 0 | ||
| let styleNames = ["Error", "Success", "Informational", "Warning"] | ||
| var body: some View { | ||
| VStack { | ||
| List { | ||
| Toggle("Shows Hint Text", isOn: self.$showsHintText) | ||
|
|
||
| Toggle("Shows Error Message", isOn: self.$showsErrorMessage) | ||
|
|
||
| Picker("Semantic Style", selection: self.$semanticIndex) { | ||
| ForEach(0 ..< self.styleNames.count, id: \.self) { index in | ||
| Text(self.styleNames[index]) | ||
| } | ||
| } | ||
| Toggle("Shows Char Count", isOn: self.$showsCharCount) | ||
|
|
||
| Toggle("Allows Beyond Limit", isOn: self.$allowsBeyondLimit) | ||
|
|
||
| Toggle("AI Notice", isOn: self.$showAINotice) | ||
|
|
||
| Toggle("longAINoticeText", isOn: self.$longAINoticeText) | ||
|
|
||
| Toggle("longHelperText", isOn: self.$longHelperText) | ||
|
|
||
| Button("Dismiss Keyboard") { | ||
| hideKeyboard() | ||
| } | ||
|
|
||
| Text("TextFieldFormView") | ||
| TextFieldFormView(title: "Label", text: self.$valueText, isSecureEnabled: false, placeholder: "Placeholder", errorMessage: self.getErrorMessage(), maxTextLength: self.getMaxTextLength(), hintText: self.getHintText(), isCharCountEnabled: self.showsCharCount, allowsBeyondLimit: self.allowsBeyondLimit, isAINoticeEnabled: self.showAINotice, isRequired: true) | ||
| .ifApply(self.showsErrorMessage) { v in | ||
| v.ifApply(self.semanticIndex == 0) { vs in | ||
| vs.textInputInfoViewStyle(.error) | ||
| }.ifApply(self.semanticIndex == 1) { vs in | ||
| vs.textInputInfoViewStyle(.success) | ||
| }.ifApply(self.semanticIndex == 2) { vs in | ||
| vs.textInputInfoViewStyle(.informational) | ||
| }.ifApply(self.semanticIndex == 3) { vs in | ||
| vs.textInputInfoViewStyle(.warning) | ||
| } | ||
| } | ||
| .aiNotice(self.$showAINotice, description: self.getNoticeText()) | ||
|
|
||
| Text("KeyValueFormView") | ||
| KeyValueFormView(title: "Label", text: self.$valueText, placeholder: "Placeholder", errorMessage: self.getErrorMessage(), maxTextLength: self.getMaxTextLength(), hintText: self.getHintText(), isCharCountEnabled: self.showsCharCount, allowsBeyondLimit: self.allowsBeyondLimit, charCountBeyondLimitMsg: "reduce the number of characters", isAINoticeEnabled: self.showAINotice, isRequired: true) | ||
| .ifApply(self.showsErrorMessage) { v in | ||
| v.ifApply(self.semanticIndex == 0) { vs in | ||
| vs.textInputInfoViewStyle(.error) | ||
| }.ifApply(self.semanticIndex == 1) { vs in | ||
| vs.textInputInfoViewStyle(.success) | ||
| }.ifApply(self.semanticIndex == 2) { vs in | ||
| vs.textInputInfoViewStyle(.informational) | ||
| }.ifApply(self.semanticIndex == 3) { vs in | ||
| vs.textInputInfoViewStyle(.warning) | ||
| } | ||
| } | ||
| .aiNotice(self.$showAINotice, description: self.getNoticeText()) | ||
|
|
||
| Text("NoteFormView") | ||
| NoteFormView(text: self.$valueText, placeholder: "Placeholder", errorMessage: self.getErrorMessage(), maxTextLength: self.getMaxTextLength(), hintText: self.getHintText(), isCharCountEnabled: self.showsCharCount, allowsBeyondLimit: self.allowsBeyondLimit, isAINoticeEnabled: self.showAINotice) | ||
| .ifApply(self.showsErrorMessage) { v in | ||
| v.ifApply(self.semanticIndex == 0) { vs in | ||
| vs.textInputInfoViewStyle(.error) | ||
| }.ifApply(self.semanticIndex == 1) { vs in | ||
| vs.textInputInfoViewStyle(.success) | ||
| }.ifApply(self.semanticIndex == 2) { vs in | ||
| vs.textInputInfoViewStyle(.informational) | ||
| }.ifApply(self.semanticIndex == 3) { vs in | ||
| vs.textInputInfoViewStyle(.warning) | ||
| } | ||
| } | ||
| .aiNotice(self.$showAINotice, description: self.getNoticeText()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func getNoticeText() -> AttributedString? { | ||
| (self.longAINoticeText && self.showAINotice) ? "Created with AI long description lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod." : "Created With AI" | ||
| } | ||
|
|
||
| func getHintText() -> AttributedString? { | ||
| self.showsHintText ? self.longHelperText ? "Helper text long description lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod." : self.hintText : nil | ||
| } | ||
|
|
||
| func getErrorMessage() -> AttributedString? { | ||
| self.showsErrorMessage ? self.errorMessage : nil | ||
| } | ||
|
|
||
| func getMaxTextLength() -> Int? { | ||
| self.showsCharCount ? 20 : nil | ||
| } | ||
|
|
||
| func getCharCountEnabled() -> Bool? { | ||
| self.showsCharCount ? true : nil | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This _TextInputInfoViewComponent changed to public without header docs. Please add header docs so that the generated structs will have docs.