Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aviti run manifest dev #359

Merged
merged 28 commits into from
Sep 16, 2024
Merged

Conversation

kedhammar
Copy link

No description provided.

@chuan-wang chuan-wang marked this pull request as ready for review September 11, 2024 13:24
Copy link
Member

@chuan-wang chuan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kedhammar kedhammar force-pushed the aviti-manifest-fix branch 2 times, most recently from f15e835 to 1eb646d Compare September 12, 2024 11:51
@kedhammar
Copy link
Author

@chuan-wang
Copy link
Member

Tested here https://ngi-lims-stage.scilifelab.se/clarity/work-details/1061255

It seems that PhiX_Adept are missing in lane 1?

@kedhammar
Copy link
Author

Tested here https://ngi-lims-stage.scilifelab.se/clarity/work-details/1061255

It seems that PhiX_Adept are missing in lane 1?

Ah, that potentially constitutes a bug if we do not also stratify by lane I suppose. Implemented a fix now!

@kedhammar kedhammar merged commit 3784cda into SciLifeLab:master Sep 16, 2024
7 checks passed
@kedhammar kedhammar deleted the aviti-manifest-fix branch September 16, 2024 09:10
@kedhammar kedhammar restored the aviti-manifest-fix branch September 16, 2024 13:44
@kedhammar kedhammar deleted the aviti-manifest-fix branch September 25, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants