Skip to content

test: make more tests green #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AayushSabharwal wants to merge 4 commits into
base: master
Choose a base branch
from
Open

test: make more tests green #4127

AayushSabharwal wants to merge 4 commits into from
+27 −11

Conversation

@AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Jan 7, 2026 •
edited
Loading

Close #4211

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 8, 2026

I'm consistently stumped by how this manages to have different behavior on LTS, and only in CI.

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jan 8, 2026

LTS doesn't obey sources

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 8, 2026

Ah, right thanks. I thought I made the CI script dev packages appropriately, but apparently not.

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 8, 2026

Hmm, but that doesn't explain the ModelingToolkitBase/InterfaceI failure. There's no sources entry in that package.

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 8, 2026

Okay yeah, that isn't it. I made the runtests.jl file dev the appropriate subpackages. Still, I think it's prudent to do it in the CI script instead. The Pkg.status printout is then always correct, and we avoid stacked environments.

@AayushSabharwal AayushSabharwal force-pushed the as/fix-more-tests branch 4 times, most recently from 1e367f3 to bdc1eba Compare January 8, 2026 15:40
@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 9, 2026

The print statements seem to affect tests passing. In fact, they affect completely unrelated tests.

@AayushSabharwal AayushSabharwal force-pushed the as/fix-more-tests branch 3 times, most recently from cdc0da3 to f5dffa9 Compare January 13, 2026 08:02
@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 27, 2026

Hopefully the suggestion in #4211 fixes the stochasticity here

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 27, 2026

It doesn't look like the fix worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

collect_vars! bug on 1.10 when loading DynamicQuantities

3 participants

@AayushSabharwal @ChrisRackauckas