-
-
Notifications
You must be signed in to change notification settings - Fork 43
Implement InputDelayESN #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement InputDelayESN #373
Conversation
|
Thanks. I have finalized the InputDelayESN implementation following the feedback: internal DelayLayer for a batteries-included approach and exposed states_modifiers for flexibility. I've also merged the latest changes from the remote branch. |
|
Nice, thanks! just a couple of minor naming things and we can merge this. Feel free to up the version too |
|
Thanks Francesco! I'm already bumping the version to 0.12.14 in Project.toml. |
src/models/esn_inputdelay.jl
Outdated
| num_delays::Int = 2, stride::Int = 1, readout_activation = identity, | ||
| states_modifiers = (), kwargs... | ||
| ) | ||
| input_mods = _wrap_layers((DelayLayer(in_dims; num_delays = num_delays, stride = stride),)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove the _wrap_layers here, since we have just the DelayLayer
src/models/esn_inputdelay.jl
Outdated
| :readout, | ||
| ), | ||
| } | ||
| input_modifiers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change name to input_delay, we just pass the single layer here
|
my bad, I didn't submit the review earlier. can you see them now? |
Description
This PR implements the
InputDelayESNmodel as requested in #314.Key Changes:
InputDelayESNinsrc/models/esn_inputdelay.jl.DelayLayer(acting as an input modifier), anESNCell, and aLinearReadout.test/models/test_esn_inputdelay.jlto verify correct constructor wiring, parameter dimensions, and consistency with theAbstractEchoStateNetworkinterface usingoutputsize.Checklist
Additional context
This PR addresses the first part of the requirements outlined in issue #314.