Add import extensions functionality on deploy #6136
Draft
+600
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success3074 tests passing in 1319 suites. Report generated by 🧪jest coverage report action from ecc3b74 |
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
6 times, most recently
from
16ad951 to
d50edc7
Compare
gonzaloriestra
force-pushed
the
refactor-import-extensions
branch
from
6fc3c69 to
ee5ba96
Compare
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
from
d50edc7 to
33bfff1
Compare
Unused types (1)
|
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
from
33bfff1 to
3ccbc1f
Compare
gonzaloriestra
changed the base branch from
refactor-import-extensions
to
graphite-base/6136
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
from
3ccbc1f to
c77d13f
Compare
gonzaloriestra
changed the base branch from
graphite-base/6136
to
fix-management-experience
5 tasks
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
from
c77d13f to
0710e55
Compare
gonzaloriestra
force-pushed
the
fix-management-experience
branch
from
ee1c795 to
5d44a22
Compare
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
from
0710e55 to
c9034e3
Compare
gonzaloriestra
force-pushed
the
fix-management-experience
branch
from
5d44a22 to
a990e97
Compare
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
from
c9034e3 to
3cc6524
Compare
gonzaloriestra
force-pushed
the
import-extensions-on-deploy
branch
from
3cc6524 to
453f4ea
Compare
gonzaloriestra
force-pushed
the
fix-management-experience
branch
from
a990e97 to
2ec9c8d
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.83.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.82.0";
\ No newline at end of file
|
1 similar comment
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.83.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.82.0";
\ No newline at end of file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/469
WHAT is this pull request doing?
How to test your changes?
shopify app deployTo add a dashboard managed extension in production, this flag can be enabled.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist