-
Notifications
You must be signed in to change notification settings - Fork 191
Fetch management_experience from App Management API #6149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a990e97
to
2ec9c8d
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.83.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.82.0";
\ No newline at end of file
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success3078 tests passing in 1320 suites. Report generated by 🧪jest coverage report action from 4ca13b0 |
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say that you could just hardcode the specification_identifiers that can should imported when running deploy
, since it's a small subset, but if it's already done that's fine!
packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts
Show resolved
Hide resolved
2ec9c8d
to
4ca13b0
Compare
ee5ba96
to
76ff289
Compare
I thought about that, because we actually have a hardcoded list of identifiers for config extensions, but I think this is the right way to do it. |
WHY are these changes introduced?
Related to https://github.com/shop/issues-develop/issues/469
When fetching the active app release with its extensions, we were incorrectly assuming all of them were cli managed.
WHAT is this pull request doing?
Uses the new management_experience field from the API to find out the dashboard managed extensions.
How to test your changes?
p shopify app import extensions
with App Management APIMeasuring impact
How do we know this change was effective? Please choose one:
Checklist