Handle Bundler::Fetcher::NetworkDownError during Bundler setup
#3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We occasionally receive reports of `Bundler::Fetcher::NetworkDownError`s happening in our telemetry. We expect errors like this occasionally and seeing them in telemetry does not really help us. For now, we can handle these errors so they don't get written to our error logging file.
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
approved these changes
Jul 30, 2025
vinistock
added
server
This was referenced Jul 30, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have received telemetry reports of
Bundler::Fetcher::NetworkDownErrors. We expect a certain number of these errors if Bundler ever encounters a networking issue, so it doesn't really help us to receive telemetry reports about it.Implementation
This rescues
Bundler::Fetcher::NetworkDownErrors inRubyLsp::SetupBundler#run_bundle_install. If Bundler encounters any network errors, the resulting exception will get caught and discarded rather than being reported to telemetry.Automated Tests
I added an automated test.